Skip to content

[POSTGRESQL] az postgres flexible-server restore: Add --sku-name and --tier arguments to allow changing compute during point-in-time restore - #33992

Open
Gabriel Lobo (thegabrielobo) wants to merge 1 commit into
Azure:devfrom
thegabrielobo:pg-flex-restore-sku
Open

Conversation

@thegabrielobo

@thegabrielobo Gabriel Lobo (thegabrielobo) commented Aug 26, 2026

Copy link
Copy Markdown

🤖 PR Validation — ⚠️ Review suggested

Breaking Changes Tests
⚠️ None ️✔️ 130/130
⚠️AzureCLI-BreakingChangeTest
⚠️postgresql
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd postgres flexible-server restore cmd postgres flexible-server restore added parameter sku_name
⚠️ 1006 - ParaAdd postgres flexible-server restore cmd postgres flexible-server restore added parameter tier

Related command
az postgres flexible-server restore

Description
Point-in-time restore previously always inherited the source server's compute SKU, so there was no way to resize a server during a restore. This adds --sku-name and --tier to az postgres flexible-server restore, matching capability already available on az mysql flexible-server restore.

Behavior:

Arguments supplied Result
Neither Unchanged — the restored server inherits the source server's SKU
--sku-name only Tier is inherited from the source server; the SKU is validated against that tier
--tier only The default SKU for that tier is used, and a warning is emitted
Both Both are validated against the location capability API

Downgrading below the source server's compute tier is rejected, so a GeneralPurpose or MemoryOptimized server cannot be restored down to Burstable.

Two changes beyond the plain argument addition are worth reviewer attention:

  1. pg_restore_validator now receives the resolved target tier rather than the source server's tier. Previously a Burstable source could never be restored with --storage-type PremiumV2_LRS; restoring Burstable → GeneralPurpose with SSDv2 now works, which is the point of allowing a tier change.
  2. Argument validation errors are re-raised as-is instead of being masked by the surrounding except Exception: raise ResourceNotFoundError(e). Without this, an invalid --tier surfaced as a confusing "not found" error rather than the actual validation message.

Tier ordering uses an explicit rank map rather than inferring order from the capability API's dictionary key order, which is not guaranteed stable.

Testing Guide

Restore with a different compute size, inheriting the source server's tier:

az postgres flexible-server restore --resource-group testgroup --name testservernew \
  --source-server testserver --sku-name Standard_D4s_v3

Restore with a different compute tier and size:

az postgres flexible-server restore --resource-group testgroup --name testservernew \
  --source-server testserver --tier MemoryOptimized --sku-name Standard_E2ds_v4

Restore with no compute arguments, which must behave exactly as before:

az postgres flexible-server restore --resource-group testgroup --name testservernew \
  --source-server testserver

Downgrading the tier must be rejected:

az postgres flexible-server restore --resource-group testgroup --name testservernew \
  --source-server <memory-optimized-server> --tier GeneralPurpose

Automated checks run locally:

  • azdev style postgresql — Pylint PASSED, Flake8 PASSED
  • azdev linter postgresql — no violations
  • New offline unit tests in test_postgres_flexible_restore_sku_params.py (7 tests, no network) covering argument registration and pg_restore_tier_validator upgrade / same-tier / downgrade / Burstable / unknown-tier cases
  • The existing recorded restore scenario test still passes and is unmodified

The recorded scenario test was intentionally left untouched: adding new commands to it invalidates the committed cassette (RecordMode.ONCE) and requires a live re-record, which is tracked as follow-up so the new arguments get end-to-end coverage.

History Notes

[POSTGRESQL] az postgres flexible-server restore: Add --sku-name and --tier arguments to allow changing compute during point-in-time restore

…and `--tier` arguments to allow changing compute during point-in-time restore

Point-in-time restore previously always inherited the source server's compute
SKU. Users can now select a different compute size and tier for the restored
server, matching the behavior already available for MySQL flexible servers.

- When neither argument is supplied, behavior is unchanged and the restored
  server inherits the source server's SKU.
- When only `--sku-name` is supplied, the tier is inherited from the source
  server and the SKU is validated against that tier.
- When only `--tier` is supplied, the default SKU for that tier is used and a
  warning is emitted.
- Downgrading below the source server's compute tier is rejected.

`pg_restore_validator` now receives the resolved target tier rather than the
source tier, so restoring a Burstable server to GeneralPurpose with
`--storage-type PremiumV2_LRS` is no longer incorrectly rejected.

Argument validation errors are also re-raised as-is instead of being masked as
`ResourceNotFoundError` by the surrounding exception handler.
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@microsoft-github-policy-service microsoft-github-policy-service Bot added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Aug 26, 2026
@microsoft-github-policy-service

Copy link
Copy Markdown
Contributor

Thank you for your contribution Gabriel Lobo (@thegabrielobo)! We will review the pull request and get back to you soon.

@microsoft-github-policy-service microsoft-github-policy-service Bot added the Auto-Assign Auto assign by bot label Aug 26, 2026
@a0x1ab

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 3 pipeline(s).

@thegabrielobo
Gabriel Lobo (thegabrielobo) marked this pull request as ready for review August 26, 2026 15:11
Copilot AI lite review requested due to automatic review settings August 26, 2026 15:11
@thegabrielobo
Gabriel Lobo (thegabrielobo) requested a review from a team as a code owner August 26, 2026 15:11
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@nasc17
nasc17 self-requested a review August 26, 2026 19:12
@yonzhan

Copy link
Copy Markdown
Collaborator

postgres

@microsoft-github-policy-service

Copy link
Copy Markdown
Contributor

Gabriel Lobo (@thegabrielobo) please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your
contributions to Microsoft open source projects. This Agreement is effective as of the latest signature
date below.

  1. Definitions.
    “Code” means the computer software code, whether in human-readable or machine-executable form,
    that is delivered by You to Microsoft under this Agreement.
    “Project” means any of the projects owned or managed by Microsoft and offered under a license
    approved by the Open Source Initiative (www.opensource.org).
    “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
    Project, including but not limited to communication on electronic mailing lists, source code control
    systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
    discussing and improving that Project, but excluding communication that is conspicuously marked or
    otherwise designated in writing by You as “Not a Submission.”
    “Submission” means the Code and any other copyrightable material Submitted by You, including any
    associated comments and documentation.
  2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any
    Project. This Agreement covers any and all Submissions that You, now or in the future (except as
    described in Section 4 below), Submit to any Project.
  3. Originality of Work. You represent that each of Your Submissions is entirely Your original work.
    Should You wish to Submit materials that are not Your original work, You may Submit them separately
    to the Project if You (a) retain all copyright and license information that was in the materials as You
    received them, (b) in the description accompanying Your Submission, include the phrase “Submission
    containing materials of a third party:” followed by the names of the third party and any licenses or other
    restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
    guidelines concerning Submissions.
  4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else
    for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
    Submission is made in the course of Your work for an employer or Your employer has intellectual
    property rights in Your Submission by contract or applicable law, You must secure permission from Your
    employer to make the Submission before signing this Agreement. In that case, the term “You” in this
    Agreement will refer to You and the employer collectively. If You change employers in the future and
    desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
    and secure permission from the new employer before Submitting those Submissions.
  5. Licenses.
  • Copyright License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
    Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
    the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
    parties.
  • Patent License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
    Your patent claims that are necessarily infringed by the Submission or the combination of the
    Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
    import or otherwise dispose of the Submission alone or with the Project.
  • Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
    No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
    granted by implication, exhaustion, estoppel or otherwise.
  1. Representations and Warranties. You represent that You are legally entitled to grant the above
    licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
    have disclosed under Section 3). You represent that You have secured permission from Your employer to
    make the Submission in cases where Your Submission is made in the course of Your work for Your
    employer or Your employer has intellectual property rights in Your Submission by contract or applicable
    law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
    have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
    You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
    REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
    EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
    PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
    NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
  2. Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
    You later become aware that would make Your representations in this Agreement inaccurate in any
    respect.
  3. Information about Submissions. You agree that contributions to Projects and information about
    contributions may be maintained indefinitely and disclosed publicly, including Your name and other
    information that You submit with Your Submission.
  4. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
    the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
    Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
    exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
    defenses of lack of personal jurisdiction and forum non-conveniens.
  5. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
    supersedes any and all prior agreements, understandings or communications, written or oral, between
    the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.


class RestoreTierValidatorTest(unittest.TestCase):

def test_upgrading_tier_is_allowed(self):

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead add new args to restore test already in project and re-record results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot customer-reported Issues that are reported by GitHub users external to the Azure organization. do-not-merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants