-
Notifications
You must be signed in to change notification settings - Fork 2.2k
KeyVault JCA: lazy-load certificate material and add alias regex filtering #49774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rujche
wants to merge
28
commits into
main
Choose a base branch
from
rujche/main/Just-load-configured-certificates-in-azure-security-keyvault-jca
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
6c8ec90
Add configured certificate filtering and lazy loading in KeyVault JCA
rujche 86621f2
Add PR link to keyvault-jca changelog entry
rujche f4371a4
Address PR review comments for alias refresh and thread safety
rujche 5507d46
Address additional PR review feedback on thread safety and refresh be…
rujche cc494aa
Make alias lookup use snapshots for thread-safe iteration
rujche b3cd9d5
Ensure refreshed aliases list remains mutable
rujche 7875700
Restore key vault precedence over classpath in keystore lookups
rujche a343059
Refine lazy key vault loads and remove brittle reflection test
rujche a6fbf69
Fix import order and remove unused import
rujche 9d74fac
Strengthen test isolation and list API assertions
rujche 162a828
Retry certificate load when Key Vault returns null
rujche d588c4d
Suppress GoodLoggingCheck and fix synchronization consistency
rujche b4aae28
Retry key and chain loads after transient failures
rujche c553796
Use lazy warning logs and remove extra suppression
rujche c73eb95
Reset key vault certificate cache when client changes
rujche 72887a0
Make key vault client update atomic and reuse cache reset
rujche ce99b3e
Ignore null configured certificate aliases
rujche 7ec6baf
Use allCertificates precedence in KeyVaultKeyStore lookups
rujche f34921f
Add GoodLoggingCheck suppression for KeyVaultCertificates
rujche 9506d26
Guard null certificate alias lookup and clarify refresh docs
rujche 35885e3
Reduce lock contention in lazy certificate loading
rujche e67607c
Add certificates-filter-patterns property for alias regex filtering
rujche 8cddbf0
Simplify certificates filter pattern README wording
rujche f1ce384
Align changelog filter pattern wording with README
rujche 470b184
Rename certificate alias filter property
rujche 524655e
Document default alias filter behavior
rujche 7662126
Reorder default filter behavior sentence in README
rujche 60907c2
Fix stale-client publish races in lazy loaders
rujche File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming the KV contains many certificates, I want to support the following filtering logic:
Forward filtering: Users can select aliases from a list of names or regular expressions. Without configuration, all aliases are read by default.
Reverse filtering: Exclusion by name or regular expression. Without configuration, no exclusions are allowed by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestion. This behavior has now been implemented and documented in this PR:
I also updated README and CHANGELOG wording to make the default behavior explicit.