[browndav-msft]

No description provided.

[azure-pipelines]

Azure Pipelines:
Successfully started running 1 pipeline(s).
34 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

[Copilot]

Copilot review overview

🟡 Changes recommended

Availability documentation is inconsistent, and wire-level tests and release notes are incomplete.

Review effort: Balanced
Findings: 2 · 2

Open (4)

• Add sync and async client tests for change-feed options · New
• Test parsing all three change-feed response headers · New
• Use the correct ShareServiceVersion in all change-feed JavaDocs · New
• Document change-feed APIs in the Unreleased changelog · New

What changed in this PR

Adds Azure Files share change-feed support using the 2027-03-07 service specification.

Changes:

• Adds change-feed create and update options.
• Maps returned change-feed properties.
• Updates generated protocol code, tests, and assets.

File	Description
swagger/​README.md	Updates the generation specification.
ModelTests.java	Adds change-feed model tests.
ShareClient.java	Sends change-feed options synchronously.
ShareAsyncClient.java	Sends change-feed options asynchronously.
ShareSetPropertiesOptions.java	Adds update options.
ShareCreateOptions.java	Adds creation options.
ShareProperties.java	Exposes returned change-feed properties.
ModelHelper.java	Maps response headers.
SharesImpl.java	Adds generated request parameters.
SharesGetPropertiesHeaders.java	Parses change-feed response headers.
assets.json	Updates test asset recordings.

---

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

🔵 Needs a closer look

Public retention setters omit the valid range, while earlier changelog and header-parser coverage requests remain unresolved.

2 open findings

• Add sync and async client tests for change-feed options
• Document change-feed APIs in the Unreleased changelog

2 resolved since last review

• Test parsing all three change-feed response headers
• Use the correct ShareServiceVersion in all change-feed JavaDocs

Previously missed (2)

In code that hasn't changed since last review

Document valid 1–365 range in setter

sdk/​storage/​azure-storage-file-share/​src/​main/​java/​com/​azure/​storage/​file/​share/​options/​ShareCreateOptions.java:318

This setter omits the 1–365 range defined by the wire contract, so callers cannot determine which values are valid from the public API documentation. State the range here, as the generated operation and ShareProperties already do.

Document valid 1–365 range in setter

sdk/​storage/​azure-storage-file-share/​src/​main/​java/​com/​azure/​storage/​file/​share/​options/​ShareSetPropertiesOptions.java:297

This setter omits the 1–365 range defined by the wire contract, so callers cannot determine which values are valid from the public API documentation. State the range here, as the generated operation and ShareProperties already do.

🧠 Review effort: Balanced

[Copilot]

🟢 Approval recommended

The request, response mapping, public API, and synchronous and asynchronous coverage are consistent and complete.

0 open findings

2 resolved since last review

• Add sync and async client tests for change-feed options
• Document change-feed APIs in the Unreleased changelog

🧠 Review effort: Balanced

[Copilot]

🟡 Changes recommended

The requested unit coverage for parsing all three response headers remains absent.

0 open findings

🧠 Review effort: Balanced

[Isabelle (ibrandes)]

looks good to me! let's wait to merge this in until after the API view meeting though, in case they request any changes.