Repository navigation
[Cosmos] Avoid redundant provisioning in fixed-account test stages - #50839
Open
Tomas Varon (tvaron3) wants to merge 3 commits into
Open
Tomas Varon (tvaron3) wants to merge 3 commits into
Tomas Varon (tvaron3) wants to merge 3 commits into
Conversation
Disable per-run ARM provisioning for six thin-client and GSI stages while preserving fixed credentials, authentication, test profiles, and cleanup. Add offline pipeline regression coverage and document the account contract. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: ead4fdd6-1296-47c8-bd5c-1cdfe90128ee
|
Azure Pipelines: Successfully started running 1 pipeline(s). 35 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Remove manual provisioning assets and offline-only test scripts, schema, and sample. Preserve the CI credential-resolution template and script, spelling configuration, and documented secret contract. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: ead4fdd6-1296-47c8-bd5c-1cdfe90128ee
Tomas Varon (tvaron3)
marked this pull request as ready for review
October 17, 2026 00:34
Tomas Varon (tvaron3)
requested review from
a team and
Kiran Kumar Kolli (kirankumarkolli)
as code owners
October 17, 2026 00:34
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Static tracing supports disabling provisioning without disrupting fixed-account tests, authentication, or cleanup, and no blocking issues remain.
No open issues 🎉
What changed in this PR
Removes redundant resource provisioning from six Cosmos live-test stages that already use fixed accounts, without changing SDK runtime behavior.
Changes:
- Disable per-run ARM provisioning while preserving fixed credentials, authentication, and database cleanup.
- Remove local-only provisioning and testing tools.
- Document the secret format and fixed-account configuration; retain resolver behavior unchanged.
| File | Description |
|---|---|
| sdk/cosmos/tests.yml | Disables provisioning for six fixed-account stages. |
| sdk/cosmos/pipeline/resolve-cosmos-test-account.tests.sh | Removes manual resolver tests. |
| sdk/cosmos/pipeline/resolve-cosmos-test-account.sh | Updates a documentation reference in a comment only. |
| sdk/cosmos/pipeline/README.md | Documents retained CI tooling and account configuration. |
| sdk/cosmos/pipeline/live-test-accounts.schema.json | Removes the unused schema. |
| sdk/cosmos/pipeline/live-test-accounts.sample.json | Removes the standalone sample configuration. |
| sdk/cosmos/pipeline/account-provisioning/README.md | Removes local provisioning instructions. |
| sdk/cosmos/pipeline/account-provisioning/New-CosmosLiveTestAccounts.ps1 | Removes the local account provisioner. |
| sdk/cosmos/pipeline/account-provisioning/cosmos-live-test-accounts.definition.json | Removes definitions used by the deleted provisioner. |
Review effort: Balanced
Alan Zimmer (alzimmermsft)
approved these changes
Oct 19, 2026
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: ead4fdd6-1296-47c8-bd5c-1cdfe90128ee
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Disable per-run ARM resource provisioning for six Cosmos live-test stages that already use fixed accounts:
Http2NetworkFault,ThinClient,ThinClient_EndpointProbe,ThinClient_MultiRegion,ThinClient_MultiMaster, andGSI(all with theCosmos_Live_Test_prefix).These stages previously inherited
DisableAzureResourceCreation: false, creating redundant accounts throughsdk/cosmos/test-resources.jsondespite selecting fixed endpoint/key credentials. The selected Maven profiles, TestNG groups, and setup paths were checked for ARM-output dependencies; they do not requireNEW_ACCOUNT_*or secondary-key outputs. Fixed credentials, test profiles, matrix inputs, federated authentication, transport selection, iptables setup, and post-job database cleanup are preserved. Other stages and the ARM template are unchanged.Remove local-only tooling from
sdk/cosmos/pipeline, while retaining everything used by CI:account-provisioning/New-CosmosLiveTestAccounts.ps1, its README and account definition JSON; the unused account schema/sample; and the two manual-only test scripts (resolve-cosmos-test-account.tests.shandtest_fixed_account_pipeline.py). No CI invocation or automated discovery of these scripts was found.resolve-test-account-steps.yml,resolve-cosmos-test-account.sh,cspell.json, and the updated README. The standard live and Http2 stages still use these resolvers for fixed-account credentials, including the secondary key. Runtime resolver behavior is unchanged; only its schema-reference comment changes.No SDK runtime or public API changes; no customer-facing changelog entry is needed. No spec regeneration applies.