Repository navigation
[Storage] STG105 Modify delete container documentation - #50853
browndav-msft merged 1 commit into
Conversation
|
Azure Pipelines: Successfully started running 1 pipeline(s). 34 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
There was a problem hiding this comment.
🔵 Needs a closer look
Service-owner confirmation is needed for the documented 30-second access window and subsequent 404 guarantee.
No open issues 🎉
What changed in this PR
Updates Azure Blob Storage and Data Lake deletion documentation without changing runtime behavior.
Changes:
- Describes delayed name reuse and temporary access after deletion.
- Applies consistent JavaDoc across synchronous and asynchronous clients.
- Records the documentation updates in both package changelogs.
| File | Description |
|---|---|
| sdk/storage/azure-storage-file-datalake/src/main/java/com/azure/storage/file/datalake/DataLakeServiceClient.java | Documents synchronous file-system deletion behavior. |
| sdk/storage/azure-storage-file-datalake/src/main/java/com/azure/storage/file/datalake/DataLakeServiceAsyncClient.java | Documents asynchronous file-system deletion behavior. |
| sdk/storage/azure-storage-file-datalake/src/main/java/com/azure/storage/file/datalake/DataLakeFileSystemClient.java | Updates synchronous delete overloads. |
| sdk/storage/azure-storage-file-datalake/src/main/java/com/azure/storage/file/datalake/DataLakeFileSystemAsyncClient.java | Updates asynchronous delete overloads. |
| sdk/storage/azure-storage-file-datalake/CHANGELOG.md | Records Data Lake documentation changes. |
| sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/BlobServiceClient.java | Documents synchronous container deletion behavior. |
| sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/BlobServiceAsyncClient.java | Documents asynchronous container deletion behavior. |
| sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/BlobContainerClient.java | Updates synchronous delete overloads. |
| sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/BlobContainerAsyncClient.java | Updates asynchronous delete overloads. |
| sdk/storage/azure-storage-blob/CHANGELOG.md | Records Blob Storage documentation changes. |
Review effort: Balanced
browndav-msft
left a comment
There was a problem hiding this comment.
Everything here looks good.
I don't think it is necessary, but we are stating a service side contract that a same-name recreation before 30 seconds is a 409 ContainerBeingDeleted and an immediate child read is a 404 ContainerNotFound, which are both correct. And then a 201 Created
Since we are making this claim for the SDK, I think it might help to have a test for this to make sure that what we are claiming for the SDK is true, although it is a service level agreement.
But not necessary.
1bddf63
into
Azure:feature/storage/stg105base
No description provided.