Skip to content

Sync eng/common directory with azure-sdk-tools for PR 17393 #50985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
azure-sdk-automation wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Sync eng/common directory with azure-sdk-tools for PR 17393 #50985

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
03fb38d
Pass optional SDK PRs safely to shared release completion
helen229 Oct 23, 2026
f6612b7
Address shared release completion review feedback
helen229 Oct 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions eng/common/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# Common engineering release history

## Unreleased

### Bugs Fixed

- Release-plan completion uses the job's `AutoReleaseSdkPullRequestUrl` when no explicit `SdkPullRequest` is supplied. An absent or empty variable is initialized to an empty string at runtime before macro expansion, so manual runs do not pass an unresolved variable. Empty initialization is logged. Existing runtime values and explicit parameters are preserved.
11 changes: 10 additions & 1 deletion eng/common/pipelines/templates/steps/mark-release-completion.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,15 @@ steps:
parameters:
SourceRootPath: ${{ parameters.SourceRootPath }}

# Runtime output variables must not be tested at template-expansion time.
# Initialize the optional macro before use on manual runs that have no SDK PR.
- ${{ if eq(parameters.SdkPullRequest, '') }}:
- pwsh: |
Write-Host '##vso[task.setvariable variable=AutoReleaseSdkPullRequestUrl]'
Write-Host 'AutoReleaseSdkPullRequestUrl is set to an empty string.'
displayName: Initialize optional auto-release SDK PR
condition: and(succeeded(), ne(variables['Skip.MarkReleaseCompletion'], 'true'), eq(variables['AutoReleaseSdkPullRequestUrl'], ''))

- task: AzureCLI@2
inputs:
azureSubscription: opensource-api-connection
Expand All @@ -19,7 +28,7 @@ steps:
arguments: >
-PackageInfoFilePath '${{ parameters.ConfigFileDir }}/${{ parameters.PackageArtifactName }}.json' -AzsdkExePath '$(AZSDK)'
-ReleasePlanId '${{ parameters.ReleasePlanId }}'
-SdkPullRequest '${{ parameters.SdkPullRequest }}'
-SdkPullRequest '${{ coalesce(parameters.SdkPullRequest, '$(AutoReleaseSdkPullRequestUrl)') }}'
-PipelineUrl "$(System.CollectionUri)$(System.TeamProject)/_build/results?buildId=$(Build.BuildId)"
workingDirectory: $(Pipeline.Workspace)
displayName: Mark package as released
Expand Down
Loading