fix(net): honor kube-proxy JSON health - #669
Open
Patrick W. Healy (phealy) wants to merge 1 commit into
Open
Conversation
Treat kube-proxy as healthy when its healthz response reports healthy=true, even when node eligibility causes an HTTP 503 response. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: b9438d58-c090-4125-b54f-64a77ce9fdac
Jason Wilder (jwilder)
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/healthzJSON instead of relying solely on HTTP statushealthy: trueas healthy when node eligibility causes HTTP 503Problem
Unbounded-managed nodes carry the
node.kubernetes.io/exclude-from-external-load-balancers=truelabel. kube-proxy intentionally reports these nodes asnodeEligible:false, so its/healthzendpoint returns HTTP 503 even while the response body reportshealthy:trueand both IPv4 and IPv6 proxy synchronization are healthy.The node monitor currently interprets every non-200 response as a kube-proxy failure. That warning is included in the node status sent to the controller, causing the controller and dashboard to report a false kube-proxy error for otherwise healthy excluded nodes.
Fix
The monitor now parses the kube-proxy health JSON and uses its
healthyfield as the authoritative proxy-health signal. A 503 response withhealthy:trueno longer creates a warning, whilehealthy:false, malformed responses, and unreachable endpoints continue to surface errors.Testing
go test ./cmd/unbounded-net-node -run '^TestKubeProxyMonitor' -count=1