hack: delete unreferenced dev-tooling helpers - #682
Open
Philip Lombardi (plombardi89) wants to merge 1 commit into
Open
hack: delete unreferenced dev-tooling helpers#682Philip Lombardi (plombardi89) wants to merge 1 commit into
Philip Lombardi (plombardi89) wants to merge 1 commit into
Conversation
Zero-reference removals in the development tooling:
- notice/internal/npm.WithFS. The identically named gomod.WithFS is used by
gomod's tests and stays.
- notice/internal/testutil.BSD3License. MITLicense, Apache2License and
WriteTree in the same file are all used.
- relctl/version.GitRepo.Dir.
- relctl/gh.Client.API, .Name and .Owner. These had callers - three lines in
client_test.go - but the test is in package gh, so it can read api, owner
and repo directly. Exported accessors that exist only for a same-package
test are surface with no reader.
- relctl's actionsError, an unexported constant in a const group whose other
members are live, which is why `unused` never reported it.
orcadev:
- hostPortFromURL had no caller outside its own test; both go.
- percentile sorted its input and delegated to percentileSorted. Only its
test called it; computeLatencyStats, the live path, calls percentileSorted
directly having sorted once. The wrapper goes and TestPercentile moves to
percentileSorted with pre-sorted input, which keeps the p0-to-min and
p100-to-max edge cases that computeLatencyStats' own test does not cover.
Refs #670
This was referenced Aug 26, 2026
Cameron Childress (cchildress)
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the #670 dead-code sweep, split by component. The tooling that produced these findings is #673; this PR is deletions only and is independent of the other eight — the file sets are disjoint, so they can be reviewed and merged in any order and in parallel.
Why two analyzers were needed to find this
unusedcannot see dead exported code underinternal/. That is a documented design decision, not a gap:unused/unused.go:48-62holds that a package uses its exported named types and a named type uses its exported methods, so every method on an exported type is transitively live because the type is exported.x/tools/cmd/deadcodedoes not close that gap on its own either.x/tools/go/callgraph/rta/rta.go:281-287,433-437— converting a value to an interface materializes its runtime type and marks every exported method of that type reachable, because reflection could call any of them. Onevar i any = xanywhere buys all ofx's exported methods a clean bill of health.So #673 adds both
deadcodeandhack/cmd/unreferenced, which resolves identifiers instead of tracing reachability. Neither subsumes the other, and findings below are attributed to whichever one saw them.hack: delete unreferenced dev-tooling helpers
Zero-reference removals in the development tooling:
gomod's tests and stays.
WriteTree in the same file are all used.
client_test.go - but the test is in package gh, so it can read api, owner
and repo directly. Exported accessors that exist only for a same-package
test are surface with no reader.
members are live, which is why
unusednever reported it.orcadev:
test called it; computeLatencyStats, the live path, calls percentileSorted
directly having sorted once. The wrapper goes and TestPercentile moves to
percentileSorted with pre-sorted input, which keeps the p0-to-min and
p100-to-max edge cases that computeLatencyStats' own test does not cover.
Refs #670
Verification
go build ./...,go vet ./...,golangci-lintover the touched trees (0 issues),make fmtproducing no diff, andgo build -tags e2e,integrationtest,storageboundary ./.... Full suite runs in CI.The eight deletion branches were reassembled onto the tooling commits and diffed against the original combined branch: byte-identical, so nothing was lost or duplicated in the split.