QuickJS#1764
Open
CedricGuillemet wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces CI coverage for building BabylonNative with the QuickJS JavaScript engine, primarily by switching the JsRuntimeHost dependency to a QuickJS-capable revision and wiring new QuickJS jobs into the GitHub Actions workflows.
Changes:
- Point
FetchContentforJsRuntimeHostat a QuickJS branch/revision. - Add new CI jobs to build with QuickJS on macOS, Win32, Linux, and Android.
- Extend the reusable Win32 and macOS build workflows to accept/select the QuickJS engine.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
CMakeLists.txt |
Switches JsRuntimeHost source to a QuickJS-capable fork/revision. |
.github/workflows/ci.yml |
Adds new QuickJS jobs across macOS/Win32/Linux/Android in CI. |
.github/workflows/build-win32.yml |
Adds QuickJS handling for napi-type to set the right CMake define and suffix. |
.github/workflows/build-macos.yml |
Adds a js-engine input and forwards it into the CMake configure step. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.