Update JsRuntimeHost to latest - #1901
Merged
bkaradzic-microsoft merged 1 commit intoSep 29, 2026
Merged
bkaradzic-microsoft merged 1 commit into
bkaradzic-microsoft merged 1 commit into
Conversation
Bump JsRuntimeHost from 839b3521 to b2b51ca8, including the napi_get_property_names conformance fixes and runtime test reorganization. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: e6c3c123-c355-4790-a3d4-94337ed6e052
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Updates the repository’s JsRuntimeHost dependency pin to the latest upstream main commit, aligning with recent upstream fixes and test organization changes.
Changes:
- Bump
JsRuntimeHostGIT_TAGpin inCMakeLists.txtfrom839b352...tob2b51ca....
| File | Description |
|---|---|
| CMakeLists.txt | Updates the pinned JsRuntimeHost commit to track the latest upstream changes. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
bghgary
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
JsRuntimeHostfrom839b3521c8a5143be6588fc8325dad5e5157a541tob2b51ca86737cf8145235226b7591c191a94355a, the latest upstreammain.Includes:
GetPropertyNamessupport, and JavaScriptCore reference-lifetime fixes.This PR changes only the JRH pin in
CMakeLists.txt, based on latest BabylonNative master after #1900. No BN compatibility changes or other dependency updates are included.Local validation: Windows x64 D3D11 / Chakra / RelWithDebInfo builds of UnitTests, Playground, and ModuleLoadTest succeeded. All 69 native tests passed, ModuleLoadTest passed, and the Native Canvas Playground validation passed (1 run, 1 pass, 0 failures).