Repository navigation
Require ViennaRNA 2.7.0 and simplify logging synchronization - #269
Merged
martin-raden merged 1 commit intoOct 15, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the review request on #267. This follow-up targets
audit/265-vienna-accessibility-thread-safety, so it contains only the requested revision to that PR.ViennaRNA 2.7.0 is the first release providing
vrna_log_lock_set(), the newest threading interface used here (release notes, pinned declaration). Require that version in configure and the conda environment, and remove the older-version logger guards. Configure also checks header versions and links the logger/prepared-window functions, including with--disable-pkg-config.README, API comments, contributor guidance, the thread-safety audit, and ChangeLog now describe the supported range. The non-OpenMP serialization branch remains: OpenMP is an independent RNAlib build option, and raising the version does not make that fallback obsolete.
Validation on Linux with GCC 14.4.0:
make tests -j2passed all seven suites in each build, including 75,901 assertions in 69 API cases.make tests -j4passed the same seven suites and 75,901 assertions. The standalonesetup-locked 4 3diagnostic matched 1,011,504 probabilities exactly with zero parameter or callback-metadata mismatches. The audit records the minimum-library build details.git diff --checkpassed.