Repository navigation
Fix canvas help sizing and toolbar labels from #97 review - #102
Merged
martin-raden merged 1 commit intoOct 7, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest review on #97 reports a full-width canvas help dialog at the top left in Edge and asks for recognizable toolbar names in the help. The help component now loads its own stylesheet, so an older cached host stylesheet cannot omit its centering, width limit, or heading styles. Moved, Release, Reset, and Undo use the same border, spacing, and colors as the toolbar buttons while retaining bold section-title text and remaining noninteractive.
Targets
issue-74-canvas-interactions, which already includes the earlier #97 fixes from #99 and #100. Addresses #97 (comment).The reported appearance was reproduced in Microsoft Edge by serving the old component with general dialog CSS lacking the newer help rules: the dialog was 1,721 px wide at (0, 0). With this change it is 540 px wide and centered, including in short windows. The reviewer's exact cache state is unknown. Regression checks cover cached dialog CSS, an independent ViewerPanel host, bounded and centered geometry, matching button appearances, keyboard opening, Escape, Close, and focus restoration.
Validation: