Fix/revenue dashboard#112
Open
ahmadalauddin wants to merge 4 commits into
Open
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Fixes the 3 reported dashboard issues + the reason none of it worked.
Turned out the DB pool was misconfigured (wrong settings, async-incompatible QueuePool, missing await), so every tenant was just getting hardcoded mock data. Fixed that first, then the actual bugs:
database_url+ asyncpg, real data flows now.revenue:{property_id}, no tenant, so tenants with the same property id saw each other's numbers. Namespaced by tenant + added a mismatch guard.Tested
docker-compose up --build. Sunset prop-001 → 2250/4, Ocean prop-001 → 0/0, separate cache keys per tenant, March now 2250 not 1000.Files:
database_pool.py,reservations.py,cache.py,dashboard.py