fix use-after-free of the timer node mutex on destruction#1180
Open
aysha-afrah26 wants to merge 1 commit into
Open
fix use-after-free of the timer node mutex on destruction#1180aysha-afrah26 wants to merge 1 commit into
aysha-afrah26 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Sleep, Delay, and Timeout nodes each own a TimerQueue whose worker thread runs the timer callback, and that callback locks a std::mutex that belongs to the node (delay_mutex_ or timeout_mutex_). Because the TimerQueue was the first-declared member it is destroyed last, after that mutex, so when a tree is torn down while a timer is still pending the worker thread (joined only in ~TimerQueue) can lock a mutex whose destructor has already run. On macOS/libc++ the pending handler then aborts the process with "mutex lock failed: Invalid argument"; on other standard libraries it is undefined behavior. It shows up as intermittent aborts in the timer and parallel teardown tests, including Parallel.Issue819_SequenceVsReactiveSequence, which the macOS CI currently skips as flaky. Declaring the TimerQueue as the last member fixes it, since ~TimerQueue() joins the worker thread while the mutex it locks is still alive. Runtime behavior for valid trees is unchanged; only the member declaration order, and therefore the destruction order, moves.