CI: retry flaky timing tests on Windows (ctest --repeat until-pass) - #1205
Merged
Merged
Conversation
The Windows and pixi-Windows jobs ran the gtest executable once, so a single wall-clock timing test missing its budget on a loaded runner failed the whole PR (RepeatTestAsync.RepeatTestAsync, SequenceTripleActionTest.TripleAction). Use ctest --repeat until-pass:3, as the macOS job already does. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Windows and pixi-Windows jobs run
behaviortree_cpp_test.exeonce. Several tests assert tight wall-clock timing, and when a shared runner is slow a single one of them turns an unrelated PR red. Seen today on #1202 (twice, two different tests) and earlier on #1193:RepeatTestAsync.RepeatTestAsync(windows-2022 Debug)SequenceTripleActionTest.TripleAction(pixi windows-2022): 673 ms against a 660 ms budgetThe macOS job already handles this with
ctest --repeat until-pass:3(and even excludesTripleAction). This PR makes the two Windows jobs run through ctest with the same retry. No test or library change; Linux jobs untouched, so real timing regressions still show up there.CI-only change that can not be tested locally: the Windows jobs of this PR are the test.
🤖 Generated with Claude Code