fix: recognize CraftEngine items in value lookups (#428)#429
Merged
tastybento merged 1 commit intodevelopfrom May 9, 2026
Merged
fix: recognize CraftEngine items in value lookups (#428)#429tastybento merged 1 commit intodevelopfrom
tastybento merged 1 commit intodevelopfrom
Conversation
Three call sites were missing CraftEngine support, so /is value hand returned "no value" for held CraftEngine items, the value panel showed a paper icon with the prettified namespaced key, and the chat output used the raw key instead of the configured display name: - Level.getCustomBlockId now checks CraftEngineHook.getItemId, so a held custom item is mapped to its namespaced ID. - Utils.getCustomBlockItemStack now delegates to CraftEngineHook.getItemStack so the panel renders the real icon. - Utils.getCustomBlockDisplayName now also reads the modern minecraft:item_name component (hasItemName/getItemName) used by CraftEngine, in addition to the legacy display.Name used by Oraxen, Nexo, and ItemsAdder. - IslandValueCommand.printValue routes string IDs through the same getCustomBlockItemStack/getCustomBlockDisplayName path used by the panel, so the chat message shows the configured display name. Requires BentoBox >= 3.15.1-SNAPSHOT (BentoBoxWorld/BentoBox#2973 for the new getItemId helper). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #428.
Summary
Level.getCustomBlockIdchecks CraftEngine viaCraftEngineHook.getItemId, so a held CraftEngine custom item is mapped to its namespaced ID instead of falling back to the vanilla material (PAPER, which has no value).Utils.getCustomBlockItemStackdelegates toCraftEngineHook.getItemStack, so the value panel renders the real custom-block icon.Utils.getCustomBlockDisplayNamenow also reads the modernminecraft:item_namecomponent (hasItemName/getItemName) that CraftEngine uses, in addition to the legacydisplay.Nameused by Oraxen, Nexo, and ItemsAdder.IslandValueCommand.printValueroutes string IDs through the samegetCustomBlockItemStack/getCustomBlockDisplayNamepath the panel already uses, so chat output shows the configured display name instead of the prettified namespaced key.Why
Issue #428 reports that with the new CraftEngine integration, custom blocks render as a generic paper icon labelled by the raw namespaced key, and
/is value handreports "no value" for held custom items. The earlier icon/name fix from #426 had no CraftEngine branches inUtils.getCustomBlockItemStackorLevel.getCustomBlockId, so CraftEngine never reached those code paths.Dependency
Requires the BentoBox
getItemIdhelper from BentoBoxWorld/BentoBox#2973. Once merged and published as a snapshot, this PR can land. (Local testing was done against a3.15.1-SNAPSHOT-LOCALbuild of BentoBox develop + the #2973 branch.)Test plan
/is value handon a CraftEngine custom item now reports the configured value with the configured display name🤖 Generated with Claude Code