Repository navigation
T-20356 Correct the comments on the size-limit guard - #4
Merged
Merged
Conversation
The endpoint does not discard an oversized record silently: it replaces it with a notice row in the source. The guard still pays for itself by not uploading megabytes that cannot land, by reporting where the application can see it and by keeping Stats honest. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verifying the oversized-record behaviour with plain curl showed that the ingest endpoint does not discard a record over the 10 MiB limit silently: it answers 2xx and replaces the record with a notice row in the source ("Individual log entry over the max allowed size of 10 MiB was dropped by Better Stack", with the original size and a 1 KiB prefix of the payload). The comments on the client-side guard said otherwise. They now describe what the guard is for: not uploading megabytes that cannot land, reporting the drop where the application can see it, and keeping
Statshonest instead of counting the record as sent. Comments only, no behaviour change.🤖 Generated with Claude Code