#155 sync close()/context manager - #160
Merged
Merged
Conversation
mirrors AsyncAPI/AsyncDatamaxi aclose/__aenter__/__aexit__
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #155
Summary
Sync client lacked
close()/context-manager support and leaked itsrequests.Session. Addedclose()/__enter__/__exit__toAPI, delegated throughDatamaxi(self._api.close()) — mirroring the asyncaclose/__aenter__/__aexit__pattern. Enableswith Datamaxi(...) as client:.Tests
API.close(),with API(), andwith Datamaxi(...)closing the session.