Repository navigation
feat(sdk-coin-canton): serialize custodial ledger-time metadata in broadcast transactions - #10075
Merged
Merged
Conversation
broadcast transactions Ticket: CHALO-1969
Contributor
Contributor
|
|
ravibitgo
marked this pull request as ready for review
October 27, 2026 08:08
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
hrishikeshjain
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve Canton custodial timing metadata through SDK transaction serialization.
When the prepare response includes custodial timing metadata, toBroadcastFormat() now serializes:
{ "minLedgerTime": { "time": { "MinLedgerTimeAbs": { "value": "<T>" } } } }The timing sidecar remains embedded in prepareCommandResponse for round-trip persistence.
Compatibility
Testing
Release note
This PR must be published and consumed by Wallet Platform before the runtime change is effective there.
Ticket: CHALO-1969