Skip to content

feat(sdk-coin-canton): serialize custodial ledger-time metadata in broadcast transactions - #10075

Merged
ravibitgo merged 1 commit into
masterfrom
CHALO-1969
Oct 27, 2026
Merged

ravibitgo merged 1 commit into
masterfrom
CHALO-1969

Conversation

@ravibitgo

Copy link
Copy Markdown
Contributor

Summary

Preserve Canton custodial timing metadata through SDK transaction serialization.

When the prepare response includes custodial timing metadata, toBroadcastFormat() now serializes:

{
 "minLedgerTime": {
   "time": {
     "MinLedgerTimeAbs": {
       "value": "<T>"
     }
   }
 }
}

The timing sidecar remains embedded in prepareCommandResponse for round-trip persistence.

Compatibility

  • Existing transactions continue to serialize minLedgerTime as Empty.
  • Prepared transaction hashes and signing payloads are unchanged.
  • fromRawTransaction() preserves timing metadata when parsing and reserializing.
  • No changes to regular Canton transaction signing.

Testing

  • Added absolute minLedgerTime serialization test.
  • Added parse/serialize round-trip coverage.
  • Focused SDK test passes.

Release note

This PR must be published and consumed by Wallet Platform before the runtime change is effective there.

Ticket: CHALO-1969

@linear-code

linear-code Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

CHALO-1969

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Unit tests are failing on Node 26.x (Current release line, non-blocking). This is not an LTS version yet, so it does not block merge, but it signals an incompatibility to fix before Node 26.x becomes LTS.

View run

@ravibitgo
ravibitgo marked this pull request as ready for review October 27, 2026 08:08
@ravibitgo
ravibitgo requested a review from a team as a code owner October 27, 2026 08:08

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@ravibitgo
ravibitgo merged commit 88b0ee3 into master Oct 27, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants