Repository navigation
feat(statics): enable staking feature for mainnet eth:zama (SI-2153) - #10079
Merged
ashutoshkumar-6 merged 1 commit intoOct 27, 2026
Merged
Conversation
Add CoinFeature.STAKING to the mainnet eth:zama ERC20 entry so the staking UI lists ZAMA in the Stake asset picker for ETH wallets. The entry previously used the default ERC20 features, so bg-ui filtered it out while the Hoodi hteth:zamamock entry (which carries STAKING) showed. The existing default features (account defaults + BULK_TRANSACTION) are kept unchanged. Flip the eth:zama statics test to assert the staking metadata, mirroring the hteth:zamamock assertions. Staking access stays gated per enterprise by the staking-service zama-staking flag. TICKET: SI-2153
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
Contributor
Contributor
|
|
Contributor
|
@claude review |
Contributor
|
Claude finished @shubham-damkondwar's task in 23s —— View job Code reviewVerdict: LGTM. I found no blocking issues.
Notes
|
shubham-damkondwar
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
CoinFeature.STAKINGto the mainneteth:zamaERC20 entry so ZAMA shows in the Stake → Select asset picker for ETH wallets on prod.Context
The bg-ui Stake asset picker is built client-side from statics and only lists tokens that have
CoinFeature.STAKING:hteth:zamamockhasSTAKING, so it shows on test.eth:zamaused the default ERC20 features (noSTAKING), so prod filtered it out.eigen,pol,reth-rocketandmaticall carrySTAKING.Staking-service already serves mainnet ZAMA: it is in the enterprise's viewable coins when the
zama-stakingflag is on, and theeth:zamacoin info is returned. The global Figment validator is also provisioned on prod.Changes
erc20Coins.ts:eth:zamanow passes[...AccountCoin.DEFAULT_FEATURES, CoinFeature.BULK_TRANSACTION, CoinFeature.STAKING]. The existing defaults are unchanged; onlySTAKINGis added.test/unit/base.ts: theeth:zama should not expose STAKINGassertion (feat(statics): enable ZAMA staking metadata (SI-609) #9623, SI-609) is changed to assert staking metadata (name, decimals, contract, mainnet network,STAKING), mirroring thehteth:zamamocktest. stZAMA LSTs and ERC-7984 confidential tokens stay excluded.Staking remains gated per enterprise by the staking-service
zama-stakingflag.Test
npx mocha test/unit/base.ts --grep "ZAMA staking feature": 4 passingtsc --noEmit, prettier and eslint on the changed files: cleanTICKET: SI-2153