Skip to content

feat(statics): enable staking feature for mainnet eth:zama (SI-2153) - #10079

Merged
ashutoshkumar-6 merged 1 commit into
masterfrom
ashutosh/SI-2153-eth-zama-staking-feature
Oct 27, 2026
Merged

ashutoshkumar-6 merged 1 commit into
masterfrom
ashutosh/SI-2153-eth-zama-staking-feature

Conversation

@ashutoshkumar-6

Copy link
Copy Markdown
Contributor

Summary

Add CoinFeature.STAKING to the mainnet eth:zama ERC20 entry so ZAMA shows in the Stake → Select asset picker for ETH wallets on prod.

Context

The bg-ui Stake asset picker is built client-side from statics and only lists tokens that have CoinFeature.STAKING:

  • hteth:zamamock has STAKING, so it shows on test.
  • eth:zama used the default ERC20 features (no STAKING), so prod filtered it out.
  • eigen, pol, reth-rocket and matic all carry STAKING.

Staking-service already serves mainnet ZAMA: it is in the enterprise's viewable coins when the zama-staking flag is on, and the eth:zama coin info is returned. The global Figment validator is also provisioned on prod.

Changes

  • erc20Coins.ts: eth:zama now passes [...AccountCoin.DEFAULT_FEATURES, CoinFeature.BULK_TRANSACTION, CoinFeature.STAKING]. The existing defaults are unchanged; only STAKING is added.
  • test/unit/base.ts: the eth:zama should not expose STAKING assertion (feat(statics): enable ZAMA staking metadata (SI-609) #9623, SI-609) is changed to assert staking metadata (name, decimals, contract, mainnet network, STAKING), mirroring the hteth:zamamock test. stZAMA LSTs and ERC-7984 confidential tokens stay excluded.

Staking remains gated per enterprise by the staking-service zama-staking flag.

Test

  • npx mocha test/unit/base.ts --grep "ZAMA staking feature": 4 passing
  • Full statics unit suite: 41348 passing
  • tsc --noEmit, prettier and eslint on the changed files: clean

TICKET: SI-2153

Add CoinFeature.STAKING to the mainnet eth:zama ERC20 entry so the
staking UI lists ZAMA in the Stake asset picker for ETH wallets. The
entry previously used the default ERC20 features, so bg-ui filtered it
out while the Hoodi hteth:zamamock entry (which carries STAKING) showed.

The existing default features (account defaults + BULK_TRANSACTION) are
kept unchanged. Flip the eth:zama statics test to assert the staking
metadata, mirroring the hteth:zamamock assertions.

Staking access stays gated per enterprise by the staking-service
zama-staking flag.

TICKET: SI-2153
@ashutoshkumar-6
ashutoshkumar-6 requested a review from a team as a code owner October 27, 2026 17:01

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@linear-code

linear-code Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

SI-2153

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Unit tests are failing on Node 26.x (Current release line, non-blocking). This is not an LTS version yet, so it does not block merge, but it signals an incompatibility to fix before Node 26.x becomes LTS.

View run

@shubham-damkondwar

Copy link
Copy Markdown
Contributor

@claude review

@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @shubham-damkondwar's task in 23s —— View job


Code review

Verdict: LGTM. I found no blocking issues.

  • Read the diff
  • Checked the defaults against the erc20() helper

modules/statics/src/coins/erc20Coins.ts

  • The erc20() helper's default features are [...AccountCoin.DEFAULT_FEATURES, CoinFeature.BULK_TRANSACTION]. The new explicit array is exactly that plus STAKING, so nothing else changes for eth:zama.
  • The feature array is inline, so the diff stays small. The existing statics convention for other staking tokens may be a shared constant. If one exists, consider using it, but this is not required.

modules/statics/test/unit/base.ts

  • The new assertions match the hteth:zamamock test, and Networks is already imported.
  • Deliberately omitting stZAMA LSTs and ERC-7984 tokens keeps the existing exclusion coverage.
  • Optional: the "stay excluded" tests are the guard against accidentally enabling staking on those, so confirm they still exist next to this block.

Notes

  • Staking stays gated per enterprise by the staking-service zama-staking flag, as the PR describes. The STAKING feature only affects asset-picker visibility. Make sure the flag is on only for the intended enterprises before the statics release goes out.
  • The Node 26.x unit-test failure is non-blocking. The change only touches static config and a test, so it is unlikely to be related, but I did not investigate the logs.
  • I did not run the tests myself. I rely on the PR's reported results (41348 passing).

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review found no issues

No high-confidence issues detected in this change.

@ashutoshkumar-6
ashutoshkumar-6 merged commit c0359ef into master Oct 27, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants