Repository navigation
fix(deps): bump follow-redirects, joi, node-forge past new advisories - #10110
Conversation
|
@claude, review |
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
|
Claude finished @abhijeet848's task in 21s —— View job Review of #10110The change does what it says and I found nothing blocking. I reviewed the diff only. I didn't run What I checked
Minor points, non-blocking
Verdict: looks good to merge once CI is green. Dropping the unrelated lockfile hunks would be nice but not required. |
|
|
9a2f21c to
88ca464
Compare
New advisories published for these three packages turned the publish workflow's CVSS 7.0 severity gate red. All three already have patched releases, so bump: follow-redirects 1.16.2 and node-forge 1.4.2 (pinned in resolutions/overrides) and joi 17.13.9 (lockfile only - its ^17.4.0 range in four coin modules is unchanged). Drop the obsolete GHSA-86w9-cpqp-85rv exclusion from osv-scanner.toml; node-forge 1.4.1 fixes it. osv-scanner before: 66 advisory groups, 7 blocking. After: 53 groups, 0 blocking. Ticket: SCAAS-11859
88ca464 to
325f17f
Compare
What
Bumps three dependencies past the security advisories published on Oct 30, which is what started blocking the publish workflow.
follow-redirects1.16.1 → 1.16.2 (pinned inresolutions/overrides)node-forge→ 1.4.2 (new pin in the same two blocks)joi17.13.8 → 17.13.9 (lockfile only; the^17.4.0range in four coin modules is unchanged)GHSA-86w9-cpqp-85rvexclusion fromosv-scanner.tomlWhy
On Oct 30, seven new advisories were published for these three packages. The publish run on Oct 31 then failed at "Enforce Vulnerability Severity Threshold" with 7 of 66 advisory groups rated CVSS 7.0 or higher. No code changed — the advisories did. All three have patched releases, so no new exclusions are needed.
node-forgeis never used at runtime: it only reaches the tree through the demo app's Cypress dev server (web-demo → @cypress/webpack-dev-server → selfsigned). It still needs pinning because the gate scans the whole installed tree, dev dependencies included.How Has This Been Tested?
yarn install --frozen-lockfilepasses; installed versions are 1.16.2 / 17.13.9 / 1.4.2.joivalidates valid input and rejects invalid input,follow-redirectsexposes its http/https agents.Checklist