Skip to content

fix(deps): bump follow-redirects, joi, node-forge past new advisories - #10110

Merged
abhijeet848 merged 1 commit into
masterfrom
SCAAS-11859-osv-advisories
Nov 2, 2026
Merged

abhijeet848 merged 1 commit into
masterfrom
SCAAS-11859-osv-advisories

Conversation

@abhijeet848

@abhijeet848 abhijeet848 commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

What

Bumps three dependencies past the security advisories published on Oct 30, which is what started blocking the publish workflow.

  • follow-redirects 1.16.1 → 1.16.2 (pinned in resolutions/overrides)
  • node-forge → 1.4.2 (new pin in the same two blocks)
  • joi 17.13.8 → 17.13.9 (lockfile only; the ^17.4.0 range in four coin modules is unchanged)
  • Drops the now-obsolete GHSA-86w9-cpqp-85rv exclusion from osv-scanner.toml

Why

On Oct 30, seven new advisories were published for these three packages. The publish run on Oct 31 then failed at "Enforce Vulnerability Severity Threshold" with 7 of 66 advisory groups rated CVSS 7.0 or higher. No code changed — the advisories did. All three have patched releases, so no new exclusions are needed.

node-forge is never used at runtime: it only reaches the tree through the demo app's Cypress dev server (web-demo → @cypress/webpack-dev-server → selfsigned). It still needs pinning because the gate scans the whole installed tree, dev dependencies included.

How Has This Been Tested?

  • osv-scanner v2.3.8 with the repo config: 66 advisory groups / 7 blocking before, 53 groups / 0 blocking after.
  • yarn install --frozen-lockfile passes; installed versions are 1.16.2 / 17.13.9 / 1.4.2.
  • Smoke check: joi validates valid input and rejects invalid input, follow-redirects exposes its http/https agents.

Checklist

  • My commits follow Conventional Commits
  • The ticket was included in the commit message as a reference
  • I have performed a self-review of my own code
  • Compiles for both Node and Browser environments — not verified (no full build run)
  • New and existing unit tests pass locally — not run

@linear-code

linear-code Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

SCAAS-11859

@abhijeet848

Copy link
Copy Markdown
Contributor Author

@claude, review

@abhijeet848
abhijeet848 marked this pull request as ready for review November 1, 2026 19:44
@abhijeet848
abhijeet848 requested review from a team as code owners November 1, 2026 19:44

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@abhijeet848
abhijeet848 requested a review from a team as a code owner November 1, 2026 19:44
@github-actions

github-actions Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @abhijeet848's task in 21s —— View job


Review of #10110

The change does what it says and I found nothing blocking. I reviewed the diff only. I didn't run yarn install, the scanner or any tests, so the PR's own test results are unverified by me.

What I checked

  • follow-redirects: the pin is bumped from 1.16.1 to 1.16.2 in both resolutions and overrides, and the lockfile entry matches.
  • node-forge: a new exact pin of 1.4.2 is added in both blocks. The lockfile entry becomes node-forge@1.4.2, node-forge@^1, so selfsigned and any other ^1 consumers resolve to the patched version.
  • joi: the lockfile moves from 17.13.8 to 17.13.9. The ^17.4.0 ranges in the coin modules already allow it, so no package.json edits are needed.
  • osv-scanner.toml: removing GHSA-86w9-cpqp-85rv is correct. The exclusion said no fix existed and last_affected was 1.4.0, and 1.4.2 is newer than that.

Minor points, non-blocking

  1. Unrelated lockfile churn. yarn.lock loses the #<sha1> fragment from the resolved URL for request@npm:@cypress/request@3.0.9, string-width@4.2.3 and strip-ansi@6.0.1. These entries have nothing to do with the three bumps. It looks like a yarn-version or registry-metadata difference when the lockfile was regenerated. It's harmless because integrity is still present. Reverting those three hunks would keep the diff focused.
  2. package.json ordering. node-forge is inserted between follow-redirects and io-ts in both blocks, which breaks the roughly alphabetical order. It belongs after minimist, near other m/n entries. This is cosmetic.
  3. Stale follow-redirects@1.16.0 key. The lockfile header still lists follow-redirects@1.16.0, which now resolves to 1.16.2. It was already stale before this PR (1.16.0 resolved to 1.16.1), and the resolution pin overrides it, so it's harmless.
  4. Exact pin maintenance. The exact node-forge pin means future patch bumps are manual. That matches how the other pins here are handled. If you'd rather not carry it, >=1.4.2 is an option, but that is a style choice.
  5. Checklist. The build and unit-test boxes are unchecked. For a lockfile-only dependency bump with the scanner and --frozen-lockfile results you report, I think that's acceptable. A quick CI run on the web-demo and joi-consuming coin modules would still be worth waiting for before merge.

Verdict: looks good to merge once CI is green. Dropping the unrelated lockfile hunks would be nice but not required.
· branch SCAAS-11859-osv-advisories

@abhijeet848
abhijeet848 requested a review from a team as a code owner November 1, 2026 19:44
@github-actions

github-actions Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

⚠️ Compatibility checks are failing on Node.js 27-nightly (experimental, non-blocking). This does not block merge, but it signals an incompatibility to fix before this release becomes supported.

View run

@abhijeet848
abhijeet848 force-pushed the SCAAS-11859-osv-advisories branch from 9a2f21c to 88ca464 Compare November 1, 2026 19:46
New advisories published for these three packages turned the publish
workflow's CVSS 7.0 severity gate red. All three already have patched
releases, so bump: follow-redirects 1.16.2 and node-forge 1.4.2 (pinned in
resolutions/overrides) and joi 17.13.9 (lockfile only - its ^17.4.0 range in
four coin modules is unchanged). Drop the obsolete GHSA-86w9-cpqp-85rv
exclusion from osv-scanner.toml; node-forge 1.4.1 fixes it.

osv-scanner before: 66 advisory groups, 7 blocking. After: 53 groups, 0 blocking.

Ticket: SCAAS-11859
@abhijeet848
abhijeet848 force-pushed the SCAAS-11859-osv-advisories branch from 88ca464 to 325f17f Compare November 1, 2026 19:52
@abhijeet848
abhijeet848 merged commit e76eb28 into master Nov 2, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants