Repository navigation
fix(express): forward query strings without deprecated url.parse - #10142
Merged
Merged
Conversation
Contributor
Contributor
|
|
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
Contributor
Author
|
@claude review |
pranavjain97
approved these changes
Nov 11, 2026
Contributor
Author
|
this is only for the express-side call site |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eliminate the DEP0169
url.parse()deprecation warning emitted by BitGo Express on proxied requests with query parameters.createAPIPathinmodules/express/src/clientRoutes.tsextracts the query string by slicingreq.urlfrom the first?up to any#, replacing the legacyurl.parse()call that triggered DEP0169.url.parse().searchbehavior, including stripping fragments; the unusedurlimport is removed.createAPIPath(v1 REST passthrough, v2 user, v2 coin-specific); local typed routes and the coin modules'getAddressDetailsurl.parsecalls are unchanged.Tests
modules/express/test/unit/clientRoutes/proxiedQueryStrings.tsruns real requests through the express app and asserts the exact upstream request path via nock: no query, simple query, percent-encoded values (%20,%27,%2B),+, repeated keys, empty value, bare?, and v2 user and v2 coin paths forwarded byte-for-byte.Ticket: WCN-4315