Repository navigation
fix(statics): pre-populate static networkFeatureMapForTokens for EVM families - #10147
Merged
nayandas190 merged 1 commit intoNov 10, 2026
Conversation
Contributor
Contributor
|
|
nayandas190
force-pushed
the
nayanjyotidas/cecho-2706-bitgojs-statics-pre-populate-static
branch
from
November 10, 2026 01:18
84fa704 to
e29efe1
Compare
nayandas190
marked this pull request as ready for review
November 10, 2026 05:30
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
Contributor
Author
|
@claude Please review |
prajwalu142
approved these changes
Nov 10, 2026
nayandas190
deleted the
nayanjyotidas/cecho-2706-bitgojs-statics-pre-populate-static
branch
November 10, 2026 05:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When the automated AMS token onboarding bot (
ams-bot-tokens) adds the first token for an EVM chain intomodules/statics/src/coins/botTokens.ts,botTokens.tscallsgetTokenFeatures('<family>', [...])at module load time.Because
coins.tsimportsallCoinsAndTokens.ts->coins/botTokens.tsbefore callingregisterErc20Families(), anySUPPORTS_ERC20EVM family not statically present innetworkFeatureMapForTokensresolvesgetTokenFeatures(family)withoutaccount-modeland throwsMissingRequiredCoinFeatureErrorat module load (which previously required manual patches forbaseeth,flow,okbxlayer,hoodeth, andchiliz).This PR:
SUPPORTS_ERC20EVM families innetworkFeatureMapForTokensinmodules/statics/src/networkFeatureMapForTokens.ts(EVM_TOKEN_FEATURESfor EIP-1559 chains andEVM_TOKEN_FEATURES_NON_EIP1559forprividiumeth).STATIC_NETWORK_FEATURE_FAMILIES(captured at module load beforeregisterErc20Families()runs) and updates the drift-guard unit test inmodules/statics/test/unit/coins.tsso any futureSUPPORTS_ERC20EVM family must also be statically listed.Issue Number
Type of change
How Has This Been Tested?
@bitgo/statics(yarn build)modules/statics/test/unit/coins.ts(41,941 passing) andmodules/statics/test/unit/tokenConfigTests.ts(191 passing)Checklist: