Skip to content

fix: patch bundled sigstore to recover from Rekor 409 conflicts - #10175

Merged
danielpeng1 merged 1 commit into
masterfrom
WCN-4669-sigstore-fetch-on-conflict-release-patch
Nov 13, 2026
Merged

danielpeng1 merged 1 commit into
masterfrom
WCN-4669-sigstore-fetch-on-conflict-release-patch

Conversation

@danielpeng1

@danielpeng1 danielpeng1 commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Fix npmjs-release failures where a Rekor transparency-log conflict kills the publish of one package

  • The sigstore client treats a Rekor 409 equivalent entry already exists as fatal, so the publish dies before the tarball uploads and recovery mode keeps failing on the same package.
  • Adds a workflow step that flips the project's node_modules/sigstore fetchOnConflict default to true before publishing (the copy lerna's publish loads), so the client fetches the entry it already created and the publish succeeds.
  • Runs in normal and recovery releases; skipped on dry-run or with disable-sigstore-patch.
  • If npm ships the upstream fix, the step becomes a warning-only no-op — delete it then.
  • Verified the patch against the project's real sigstore config and simulated all outcomes (patched, already fixed, target gone, unwritable); the next release run is the end-to-end proof.

Ticket: WCN-4669

@danielpeng1 danielpeng1 self-assigned this Nov 13, 2026
@danielpeng1
danielpeng1 requested review from a team as code owners November 13, 2026 05:41

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@linear-code

linear-code Bot commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

WCN-4669

Comment thread .github/workflows/npmjs-release.yml Resolved

@vibhavgo vibhavgo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also wire this in as an input boolean type
So by default it is regular fetchOnConflict: true
But when set it does fetchOnConflict: false

@danielpeng1
danielpeng1 force-pushed the WCN-4669-sigstore-fetch-on-conflict-release-patch branch from b9d3e64 to 7b9724d Compare November 13, 2026 06:11
@danielpeng1

Copy link
Copy Markdown
Contributor Author

We could also wire this in as an input boolean type So by default it is regular fetchOnConflict: true But when set it does fetchOnConflict: false

basically did the inverse of this, but the end behaviour seems to be the same

@danielpeng1
danielpeng1 requested a review from vibhavgo November 13, 2026 06:24

@vibhavgo vibhavgo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@danielpeng1
danielpeng1 merged commit d4fda12 into master Nov 13, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants