Skip to content

fix(sdk-lib-safes): omit ecdsaMpc safe slot for zec and tzec - #10180

Merged
danielpeng1 merged 1 commit into
masterfrom
WCN-4678-safe-slots-omit-zec-tss-slot
Nov 13, 2026
Merged

danielpeng1 merged 1 commit into
masterfrom
WCN-4678-safe-slots-omit-zec-tss-slot

Conversation

@danielpeng1

Copy link
Copy Markdown
Contributor

Omit the ecdsaMpc safe slot for coins that also support the Pallas curve (zec, tzec).

  • Add a hasTssSlot helper that reads otherSupportedKeyCurves from statics, with no hardcoded coin list. tssSlotForCoin and safeSlotsForCoin both use it, so they cannot disagree.
  • safeSlotsForCoin('zec' | 'tzec') now returns ['secp256k1Multisig'].
  • tssSlotForCoin('zec' | 'tzec') throws the existing "not supported for safe wallet minting" error, so Safe.createWallet({ multisigType: 'tss' }) fails before any network call.
  • Update the safeSlotsForCoin doc comment to match.
  • Every other coin's slots are unchanged.

Tests

  • sdk-lib-safes/test/unit/safeSlot.ts: zec and tzec slot lists and tssSlotForCoin throws, trx and arbeth still return both slots, and statics carry Pallas only on zec and tzec.
  • sdk-core/test/unit/bitgo/safe/safe.ts: createWallet({ coin: 'tzec', multisigType: 'tss' }) rejects before any derivation-index call, and a tzec onchain mint still works from slot 1.

Ticket: WCN-4678

@danielpeng1 danielpeng1 self-assigned this Nov 13, 2026
@linear-code

linear-code Bot commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

WCN-4678

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Compatibility checks are failing on Node.js 27-nightly (experimental, non-blocking). This does not block merge, but it signals an incompatibility to fix before this release becomes supported.

View run

@danielpeng1
danielpeng1 marked this pull request as ready for review November 13, 2026 22:14
@danielpeng1
danielpeng1 requested review from a team as code owners November 13, 2026 22:14

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@danielpeng1
danielpeng1 merged commit e4db6b4 into master Nov 13, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants