Repository navigation
fix: reject non-canonical varint encodings - #25
Merged
prikshitchawla300 merged 1 commit intoNov 11, 2026
Merged
prikshitchawla300 merged 1 commit into
prikshitchawla300 merged 1 commit into
Conversation
varuint.decode() accepted non-minimal CompactSize encodings (e.g. fd 03 00 for 3), while callers advance by encodingLength(value). The two only agree for minimal encodings. decode() now throws "Format Error: non-canonical varint encoding" for fd/fe/ff-prefixed values that fit in a shorter encoding, matching Bitcoin Core's ReadCompactSize.
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
prikshitchawla300
enabled auto-merge
November 11, 2026 07:49
abhi-bitgo
approved these changes
Nov 11, 2026
prikshitchawla300
deleted the
prikshitchawla/cshld-2225-bip174-psbt-parser-advances-offset
branch
November 11, 2026 08:05
|
🎉 This PR is included in version 3.1.0-master.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
varuint.decode()accepted non-minimal CompactSize encodings (for examplefd 03 00for 3), while its callers advance byencodingLength(value). The two only agree for minimal encodings.decode()now throwsRangeError: Format Error: non-canonical varint encodingforfd/fe/ff-prefixed values that fit in a shorter encoding. This matches Bitcoin Core'sReadCompactSize.Changes
ts_src/lib/converter/varint.ts: reject non-minimal encodings indecode().tests/varint.ts: non-minimal encodings for each prefix, including both sides of each boundary.tests/fixtures/fromBuffer.ts: non-minimal key and value lengths throughPsbt.fromBuffer.tests/converters.ts(new): nested decoders (witnessUtxo,tapTree,tapBip32Derivation, proprietary keys).src/: rebuilt output.Notes for consumers
bitcoinjs-libdeep-imports this varint module, so it also gets the stricter decoder. Its callers advance bydecode.bytes, which is still set correctly.@bitgo-forks/bip174need a version bump to pick this up.Testing
npm test(prettier, tslint, build, coverage) passes: 415/415.