Set 'rel' to 'external' on network anchor tags.#619
Open
Randy808 wants to merge 1 commit into
Open
Conversation
Explicitly set font size for '.network-hover-menu-option' class.
FedOken
reviewed
May 14, 2026
| id={name.replace(/ /g, "")} | ||
| href={url} | ||
| className={`network-hover-menu-option-container ${name.replace(/ /g, "").toLowerCase()} ${name === activeName ? "active" : ""}`} | ||
| rel="external" |
Collaborator
There was a problem hiding this comment.
I'm not quite sure why this is here. Usually, this points to external resources, but our links are to internal paths.
Collaborator
There was a problem hiding this comment.
Maybe it's should be for the links in the footer? Since those links lead to external resources
| padding-bottom: 8px; | ||
| cursor: pointer; | ||
| transition: .5s all; | ||
| font-size: 16px; |
Collaborator
There was a problem hiding this comment.
I didn't find any changes in Firefox after adding the explicit font style (macOS). But it doesn't break anything, so that's fine, just for notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicitly set font size for '.network-hover-menu-option' class.