sdk: Stable numeric error codes for i18n support#716
Open
cdecker wants to merge 2 commits into
Open
Conversation
Replace tuple-style error variants with named-field variants carrying code (i32), message (String), and values (HashMap<String, String>). This allows host-language callers to look up translated error strings by numeric code and interpolate structured values, rather than parsing English messages. Error code ranges: 1000-1099 node identity, 1100-1199 credentials, 2000-2099 RPC, 3000-3099 input validation, 9000-9099 generic. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
code: i32,message: String, andvalues: HashMap<String, String>valuesmap provides structured interpolation keys so callers can fill translated templates (e.g.,"Node {node_id} already exists")Error::rpc(),Error::other(), etc.) keep call sites clean.code,.message,.valueson error subclassesTest plan
cargo build -p gl-sdkcompiles cleanlycode,message,valuesattributes on allErrorsubclassesval code: Int,val message: String,val values: Map<String, String>code: Int32, message: String, values: [String: String]🤖 Generated with Claude Code