gl-plugin: Re-enable LSPS2 JIT htlc_accepted hook#733
Open
cdecker wants to merge 1 commit into
Open
Conversation
This partially reverts 35446f9 ("gl-plugin: Remove legacy LSPS2 htlc_accepted hook"), restoring the client-side LSPS2 htlc_accepted hook. The hook amends the incoming onion payload for JIT channel openings so the node accepts an HTLC carrying a reduced amount (the invoice amount minus the LSP opening fee) and forwards the invoice's total_msat downstream. Restores: - lsp.rs: the htlc_accepted hook implementation - lib.rs: mod lsp declaration and .hook("htlc_accepted", ...) registration The dead messages.rs HtlcAccepted* structs and test that 35446f9 also removed are intentionally left out; they were unused duplicates superseded by the structs defined in lsp.rs. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-enables the client-side LSPS2 JIT
htlc_acceptedhook ingl-plugin, which was removed in 35446f9 ("gl-plugin: Remove legacy LSPS2 htlc_accepted hook").The hook amends the incoming onion payload for JIT channel openings so the node accepts an HTLC carrying a reduced amount — the invoice amount minus the LSP opening fee — and forwards the invoice's
total_msatdownstream.What's restored
libs/gl-plugin/src/lsp.rs— theon_htlc_acceptedhook implementationlibs/gl-plugin/src/lib.rs—mod lspdeclaration and.hook("htlc_accepted", lsp::on_htlc_accepted)registrationIntentionally not restored
The dead
messages.rsHtlcAccepted*structs and their test that 35446f9 also removed are not brought back — they were unused duplicates superseded by the structs defined inlsp.rs.Notes
This is a partial revert (JIT acceptance code only).
cargo check -p gl-pluginpasses.🤖 Generated with Claude Code