Repository navigation
feat(avatar): draw every other part starting from the built-in style - #1243
Conversation
Outfit, accessory, beard, glasses, nose, cheeks, petals and flower base gain "Draw or edit this piece": the editor starts from the worn part flattened by replacePartStart (pixelaccurate, recolorable where exact), uses one layer over a backdrop without that part, and wears the saved part in its slot. Picking a built-in style only upgrades the recipe when it takes a drawn part off, which also fixes built-in hair choices upgrading version 1 recipes. Uses @botharness/pixel-avatar 0.7.0. Issue: #1240 Agent-Task: claude/cloud/session_01MozvQ2eMvqX1MzSqm9G2o8 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MozvQ2eMvqX1MzSqm9G2o8
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
⛔ Files ignored due to path filters (3)
📒 Files selected for processing (16)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe avatar editor now supports drawing and editing custom outfit, accessory, beard, glasses, nose, cheeks, petal, and flower-base parts. The workflow uses replacement-part helpers from pixel-avatar 0.7.0. The editor test covers drawing and saving a custom outfit. ChangesCustom avatar parts
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Feature Merge Risk: ⚪ Minimal · up to No identified issue blocks merging the expanded avatar-part drawing workflow after normal checks. 🚥 Pre-merge checks | ✅ 3 | ❌ 1 | ❓ 1❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
Full details: Linked Issues checkExplanation Direct issue Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 5 files. (5 skipped: 5 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Closes #1240. Part of spec #1209. This PR uses
@botharness/pixel-avatar0.7.0 (BotHarness/BotPixel#15).What you can draw now
replacePartStart:Wearing and switching back
Rendering (BotPixel)
Fix for a regression from #1242: picking a built-in style in a part category (hair included) only upgrades the recipe when it takes a drawn part off. Before this, picking built-in bangs on a version 1 Avatar upgraded it to version 2.
Evidence
I captured this on an isolated DSH instance built from this branch. The speech is simulated. Details: docs/assets/pr/1240-drawn-parts.
Verification
pnpm typecheck,pnpm lint,pnpm formatand the Release Ledger check all pass.vitest run: 3465 passed.client-observer.test.tsfails in this container because it can't bundlenode:sqlite; it fails the same way on a clean tree.outfitpart and savesoutfitPart.Agent-Task:
claude/cloud/session_01MozvQ2eMvqX1MzSqm9G2o8🤖 Generated with Claude Code
https://claude.ai/code/session_01MozvQ2eMvqX1MzSqm9G2o8
Generated by Claude Code
Summary by CodeRabbit