Repository navigation
fix(client): synchronize companion anchors on direct motion - #1249
DoodleBears wants to merge 2 commits into
Conversation
Pointer and policy updates committed the character before the frame loop committed its bubble origin, leaving a stale tether on reduced-motion release. Present both together through the mounted view lifecycle. This correction was first produced under the existing #1177 task claim before discovering that PR #1183 had concurrently merged its preceding head. Issue: #1248 Refs: #1177 Agent-Task: codex/local/01a11734-bb09-7f01-9d45-adc0f5df6269
Keep the 737px failed first-release observation alongside the corrected 0px observation, real canonical replies, five screenshots and two continuous silent recordings. Capture source fbb2975 is tree-identical to dedicated follow-up 426167c; settled PNGs do not show the transient. Issue: #1248 Agent-Task: codex/local/01a11734-bb09-7f01-9d45-adc0f5df6269
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 3 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
⛔ Files ignored due to path filters (7)
📒 Files selected for processing (6)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Closing as superseded: the same direct-motion correction is already on Generated by Claude Code |
Issue #1248 · Parent #1177 · Agent claim
Closes #1248 · Refs #1177 · Task
codex/local/01a11734-bb09-7f01-9d45-adc0f5df6269Why the change
Releasing a Window Companion in reduced motion could return the character to the floor before its connector followed, so direct motion now presents the character and bubble origin together.
Special things to note
85e9dfbe. Runtime capturefbb29752has an identical complete tracked tree to follow-up426167c9; current head adds only media and ledger references. Captures are attributed to their actual execution source.Change outline
Real DSH reduced-motion release — Chinese, 1559 × 865, dark
Same isolated Profile, identities, history, viewport, theme and native drag/release scenario; new reply marker and sidebar unread count differ. These settled PNGs do not show the transient defect. An independent read-only observer measures the first rAF callback after trusted native pointerup:
Continuous baseline recording · Continuous corrected recording, 36.167s. Silent official MCP output, container-remuxed only; downloadable repository WebM files, no inline video-player claim. The first observed callback is not proof about every compositor frame; no invented first-frame screenshot is supplied.
Corrected reading and native keyboard movement — both themes
Two exact new Bot-authored replies are checked against canonical Channel messages. Native pause controls stop walking; public character focus retains reading. All four phases remain in one document, cards upright and within the viewport; Avatar Appearance/image fields are unchanged. Console inspection found0JavaScript errors; owned test pages/browser closed.
The initial baseline setup timed out waiting for visible cards despite real replies. That attempt is preserved privately. A subsequent baseline adds live-stream and outside-focus preconditions, without claiming which change caused recovery, and exposes the737px defect. Sanitized qualification · Setup and limits.
Validation
Mounted public-View regression: red before the fix (300px stale origin), green after, inspecting the immediate committed DOM without another animation frame. Focused8tests, Client144files/1,038tests, typecheck, lint/source policy, format, bilingual ledgers and build pass; existing warnings remain. No local Windows full-suite pass is claimed. Full current-head CI37879666979 passed in5m40s, including repository tests, build and generated-output checks. Final Standards and Spec reviews against85e9dfbe each report0actionable findings. All5published images and2recording links were verified in the actual GitHub page; the verification browser was closed. Ready for review; no merge performed.