Skip to content

Move mobile search to the top of Chats in ADR-0211 and DESIGN.md - #1864

Merged
DoodleBears merged 1 commit into
mainfrom
claude/project-thread-mjx55w
Oct 15, 2026
Merged

DoodleBears merged 1 commit into
mainfrom
claude/project-thread-mjx55w

Conversation

@DoodleBears

Copy link
Copy Markdown
Contributor

Requested by Vain · project thread

Why the change

In #1851 (PR #1861), Vain pointed out that chat apps put search at the top of the conversation list, not in a bottom slot. ADR-0211 and DESIGN.md (merged in #1856) still describe an iOS search tab.

Refs #1848, #1849, #1851.

Special things to note

  • Merge risk: docs only (ADR-0211, its pointer in ADR-0201, DESIGN.md Structure). Plain revert.
  • Verification: pnpm lint passes locally; Prettier is clean on the changed files.
  • CI test plan: docs only; no rule change.

Change outline

Before: the tab bar had Chats, Activity and an iOS role="search" tab, with the field at the bottom above the keyboard; Android had a top search bar.

After:

  • ADR-0211: the tab bar has only Chats and Activity. A search field sits at the top of the Chats list, above the shortcut cards, and scrolls away with the list, on iOS and Android alike. The iOS search tab moves to Considered Options with the reason.
  • DESIGN.md: the Tabs, Chats and Search bullets match PR Search PersonaBots and Channels from the top of the phone's chat list #1861 (filters in place, prefix matches first, shortcut cards hide while searching, one-line no-match notice). The web preview no longer draws a round search button.
  • ADR-0201: its pointer to ADR-0211 no longer mentions a search tab.

🤖 Generated with Claude Code

https://claude.ai/code/session_016edM3irczgqKnFq8i3q8hf


Generated by Claude Code

Search is now a field at the top of the Chats list that scrolls away
with it, as #1851 builds it, instead of an iOS search tab. Record the
search tab as a considered option and drop it from the tab bar.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016edM3irczgqKnFq8i3q8hf
@DoodleBears DoodleBears self-assigned this Oct 15, 2026
@coderabbitai

coderabbitai Bot commented Oct 15, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 51 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: f447944c-0662-49d6-aa78-e78617cc9c5a
📥 Commits

Reviewing files that changed from the base of the PR and between cb1fc59 and 7e3e8a3.

📒 Files selected for processing: 3
  • apps/mobile/DESIGN.md
  • docs/adr/0201-the-mobile-design-system-maps-web-roles-onto-native-components.md
  • docs/adr/0211-the-mobile-app-has-two-tabs-with-settings-and-hosts-in-the-header.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@DoodleBears
DoodleBears merged commit 7d9212b into main Oct 15, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants