Repository navigation
Move mobile search to the top of Chats in ADR-0211 and DESIGN.md - #1864
Merged
Merged
Conversation
Search is now a field at the top of the Chats list that scrolls away with it, as #1851 builds it, instead of an iOS search tab. Record the search tab as a considered option and drop it from the tab bar. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016edM3irczgqKnFq8i3q8hf
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 51 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Vain · project thread
Why the change
In #1851 (PR #1861), Vain pointed out that chat apps put search at the top of the conversation list, not in a bottom slot. ADR-0211 and DESIGN.md (merged in #1856) still describe an iOS search tab.
Refs #1848, #1849, #1851.
Special things to note
pnpm lintpasses locally; Prettier is clean on the changed files.Change outline
Before: the tab bar had Chats, Activity and an iOS
role="search"tab, with the field at the bottom above the keyboard; Android had a top search bar.After:
🤖 Generated with Claude Code
https://claude.ai/code/session_016edM3irczgqKnFq8i3q8hf
Generated by Claude Code