Repository navigation
feat(mobile): pick a DeepSeekBot app icon in settings - #1877
Merged
Merged
Conversation
Me gains an Interface section with App icon: keep the shipped default icon or switch the home screen icon to one of two DeepSeekBot portraits (full and chibi), with iOS dark and tinted variants and Android adaptive icons, through expo-alternate-app-icons. Needs a new development build. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RfAkkwkrmKJLy2rzGuTaZ1
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 42 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Move the App icon row from the removed Me tab into the Settings sheet's Interface section, next to Customize header. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RfAkkwkrmKJLy2rzGuTaZ1
DoodleBears
marked this pull request as ready for review
October 15, 2026 08:58
Contributor
Author
Batch QA — head 4bd3fd5 (native; Simulator dev client rebuilt with it)iOS Simulator "PR1800 glass" (iOS 26.0, iPhone 17 Pro), dev client rebuilt from the batch, QA Host on DeepSeek. Screenshots are redacted (computer name, tailnet host and local paths blacked out). Chinese text renders as □ because the iOS 26.0 Simulator runtime ships without PingFang; that is an environment limit, not the app. Android: untested.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Vain · project thread
Why the change
The Human wants the phone's home screen icon to be a DeepSeekBot portrait, picking between two, with today's icon staying the default / 主屏幕图标可以换成两种 DeepSeekBot 头像，默认仍是现在的图标。
Special things to note
expo-alternate-app-icons@8.0.0(native module + config plugin), so the installed dev build is stale; it needs a new development build. The primary icon is untouched (still the template placeholder, sinceapp.jsonsets noicon). Revert = revert this PR and rebuild.packages/client/assets/bot/deepseekbot-{light,dark}.pnganddeepseekbot-simple-{light,dark}.png. The only copies in the repos are 128×128, so the 1024 icons are Lanczos upscales (soft at 1024, fine at home-screen sizes). Higher-resolution originals would be a drop-in replacement.#252525background, from the-darkportrait) and tinted (grayscale) variants. iOS shows its own "You have changed the icon" alert.pnpm --filter @botharness/mobile typecheck✅;pnpm vitest run apps/mobile263 passed / 8 skipped ✅ (newtest/app-icon-settings.test.tsx: default selected, switch and back to default, refusal keeps the old icon with a notice, unsupported phone shows rows without actions;settings-sheet.test.tsxcovers the new row);pnpm lint✅;EXPO_OFFLINE=1 pnpm export✅;expo prebuild --no-installgeneratesDeepSeekBot.appiconset/DeepSeekBotSimple.appiconsetwith light/dark/tinted entries,ASSETCATALOG_COMPILER_ALTERNATE_APPICON_NAMES, and two Android activity-aliases ✅. Not run yet: native Simulator check and screenshots (in the combined Simulator batch with a dev-client rebuild).scripts/ci-plan.mjsrule forapps/mobile/assets/**(and regenerated the table indocs/agents/development-scripts.md).Change outline
/app-icon: three rows (Default, DeepSeekBot, DeepSeekBot Chibi) with an icon preview, the current one checked;SettingsRow/SettingsSection, tokens only.src/ui/app-icon-settings.tsx(component behind anAppIconPort),src/ui/native-app-icon.ts(expo module + preview images), strings in en/zh,DESIGN.mdSettings note.Light and dark Simulator screenshots of the settings screen and the home screen come from the Simulator batch run as a comment on this PR.
🤖 Generated with Claude Code
https://claude.ai/code/session_01RfAkkwkrmKJLy2rzGuTaZ1