Skip to content

Match a group Bot's last bubble corner to its avatar on mobile - #1892

Merged
DoodleBears merged 3 commits into
mainfrom
claude/mobile-group-channel-native-91hm5z
Oct 15, 2026
Merged

DoodleBears merged 3 commits into
mainfrom
claude/mobile-group-channel-native-91hm5z

Conversation

@DoodleBears

Copy link
Copy Markdown
Contributor

Why the change

In a mobile group Channel the Bot avatar (rounded square, radius.sm) sits level with the bottom of the Bot's last bubble, but the bubble's bottom-left corner used the larger radius.lg, so the two bottom edges met with mismatched corners / 头像与最后一个 bubble 下沿对齐后,两者圆角大小不一致,看起来不舒服。

Refs #1890

Special things to note

  • Merge risk: low. Style-only change to the last Bot bubble (and a streaming draft) in group Channels; Bot DMs and Human bubbles are unchanged. Revert is one commit.
  • Verification: vitest in apps/mobile (294 passed, new bubbleShape case), tsc --noEmit, oxlint and oxfmt clean. Web build (pnpm export:web) against an isolated Host, light and dark screenshots below. Native iOS/Android not run here; queued in the simulator QA list.
  • CI test plan: affected.

Change outline

Before: the last Bot bubble in a group had a 16 pt bottom-left corner next to an 8 pt rounded-square avatar.

After: that corner uses the avatar's radius.sm (AVATAR_CORNER), so the avatar and the bubble share the same corner where their bottom edges meet. Inner joined corners stay radius.xs, Bot DMs keep radius.lg.

How: bubbleShape takes an avatar flag and MessageBubble/DraftBubble pass it when a group speaker is the group's last row; SpeakerAvatar reads the same AVATAR_CORNER.

Light Dark
Before
After
After, close-up

🤖 Generated with Claude Code

https://claude.ai/code/session_01YXLBzevwCYAWycH1iTuBwK


Generated by Claude Code

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01YXLBzevwCYAWycH1iTuBwK
@coderabbitai

coderabbitai Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 38bc66d3-b721-4f12-9e24-458ed5d665ea
📥 Commits

Reviewing files that changed from the base of the PR and between 90b9916 and 17b12c0.

⛔ Files ignored due to path filters: 4
  • .github/pr-screenshots/mobile-avatar-corner/channel-dark.png is excluded by !**/*.png
  • .github/pr-screenshots/mobile-avatar-corner/channel-light.png is excluded by !**/*.png
  • .github/pr-screenshots/mobile-avatar-corner/corner-dark.png is excluded by !**/*.png
  • .github/pr-screenshots/mobile-avatar-corner/corner-light.png is excluded by !**/*.png
📒 Files selected for processing: 6
  • apps/mobile/DESIGN.md
  • apps/mobile/src/ui/chat/bubble-shape.ts
  • apps/mobile/src/ui/chat/message-bubble.tsx
  • apps/mobile/src/ui/chat/speaker-row.tsx
  • apps/mobile/test/bubble-shape.test.ts
  • changes/1892-mobile-avatar-corner.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01YXLBzevwCYAWycH1iTuBwK
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01YXLBzevwCYAWycH1iTuBwK
@DoodleBears
DoodleBears merged commit ebf682d into main Oct 15, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants