Repository navigation
Match a group Bot's last bubble corner to its avatar on mobile - #1892
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YXLBzevwCYAWycH1iTuBwK
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YXLBzevwCYAWycH1iTuBwK
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YXLBzevwCYAWycH1iTuBwK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why the change
In a mobile group Channel the Bot avatar (rounded square,
radius.sm) sits level with the bottom of the Bot's last bubble, but the bubble's bottom-left corner used the largerradius.lg, so the two bottom edges met with mismatched corners / 头像与最后一个 bubble 下沿对齐后,两者圆角大小不一致,看起来不舒服。Refs #1890
Special things to note
vitestinapps/mobile(294 passed, newbubbleShapecase),tsc --noEmit,oxlintandoxfmtclean. Web build (pnpm export:web) against an isolated Host, light and dark screenshots below. Native iOS/Android not run here; queued in the simulator QA list.Change outline
Before: the last Bot bubble in a group had a 16 pt bottom-left corner next to an 8 pt rounded-square avatar.
After: that corner uses the avatar's
radius.sm(AVATAR_CORNER), so the avatar and the bubble share the same corner where their bottom edges meet. Inner joined corners stayradius.xs, Bot DMs keepradius.lg.How:
bubbleShapetakes anavatarflag andMessageBubble/DraftBubblepass it when a group speaker is the group's last row;SpeakerAvatarreads the sameAVATAR_CORNER.🤖 Generated with Claude Code
https://claude.ai/code/session_01YXLBzevwCYAWycH1iTuBwK
Generated by Claude Code