Repository navigation
Tap a day's bar on the phone's Usage screen to see that day - #1911
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01U1JSurmR8K71uTv8K3rT4w
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 24 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01U1JSurmR8K71uTv8K3rT4w
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Vain · project thread
Why the change
On the phone's Usage screen you could see 7 daily bars but not how many tokens any one day used; now, like the iOS Health app, tapping a bar shows that day.
Refs #1896, follows #1899.
Special things to note
overviewUsage), so CLI parity is unchanged (deepseekbot overview-usagealready returns each day). Tapping a bar replaces the dates and total above the chart with that day's date and tokens (N+when the Host marks the day partial) and dims the other bars to the newchart.dim. Tapping the same bar again, or switching Today / Last 7 days, shows the week again. By kind and By PersonaBot stay on the week.DayBarstakes optionalselected/onSelect; withoutonSelect(the Settings card, and Show a Bot's last 7 days on the mobile profile, with an Activity screen for the detail #1903's profile chart) the bars stay a plain picture, so the card's tap still opens Usage. VoiceOver keeps reading the whole week from the chart's label. Revert is a plain revert.pnpm typecheck,pnpm lint,pnpm format:check,vitest run apps/mobile(42 files) pass. New screen tests: tapping a quiet day shows0 tokensand its date, tapping a busy day shows its tokens, tapping it again shows the week total; switching the period forgets the picked day.node scripts/e2e-mobile-usage-web.mjspasses against a fresh isolated Host with the real model, and now also taps a quiet day (headline0 tokens), a busy day (that day's tokens) and the busy day again (week total).Change outline
src/ui/primitives/day-bars.tsx: each day column is aPressable(disabled withoutonSelect), dimmed when another day is selected.src/ui/usage-view.tsx:UsageSummarykeeps the picked day and shows it in the headline;src/host/usage.tscarries each day'spartial.apps/mobile/DESIGN.md, the verify feature map and the e2e journey describe and check the tap.Before (week) and after (a quiet day tapped), web export 390 × 844, live Host data:
🤖 Generated with Claude Code
https://claude.ai/code/session_01U1JSurmR8K71uTv8K3rT4w
Generated by Claude Code