Repository navigation
Keep a routine's next runs in view while typing its time, and name Delete for VoiceOver - #1914
Merged
Merged
Conversation
… VoiceOver Issue: #1897 Agent-Task: claude/cloud/session_01QvN8ywuXcKzbbQRkufut27 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QvN8ywuXcKzbbQRkufut27
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 54 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Vain · project thread
Follow-up to #1902 (#1897). It fixes the two small issues the Simulator batch found: #1902 (comment)
Before: in the routine editor on iOS, focusing Time or Hours brought up a keyboard that sat on the field's bottom edge and hid Next runs. The routine sheet's Delete row dropped its accessibility label whenever another action was running, so VoiceOver could not name it.
After: the editor's scroll view insets for the keyboard, and focusing Time or Hours scrolls to the end, so the field and Next runs stay visible. The Delete row always has the "Delete" label and ignores taps while another action runs.
How:
automaticallyAdjustKeyboardInsetsand an interactive dismiss on the editor'sScrollView. Time and Hours focus scrolls it to the end once the keyboard has shown. Delete keeps anonPressthat returns early while busy, instead of becoming undefined. A new test covers the label staying usable while Run now is pending.Verification:
pnpm lint,pnpm format:check, mobiletypecheckandpnpm vitest run apps/mobile(370 passed). Not run here: the Simulator check of the keyboard layout. It goes in the next simulator batch.No changelog fragment: the feature is still in Unreleased under
changes/1897-mobile-routines.md.🤖 Generated with Claude Code
https://claude.ai/code/session_01QvN8ywuXcKzbbQRkufut27
Generated by Claude Code