Skip to content

fix(mobile): full-client icon in the chat header uses the foreground colour - #1918

Open
DoodleBears wants to merge 1 commit into
mainfrom
claude/mobile-chat-header-3bkg6h
Open

DoodleBears wants to merge 1 commit into
mainfrom
claude/mobile-chat-header-3bkg6h

Conversation

@DoodleBears

@DoodleBears DoodleBears commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Requested by Vain · project thread

Before: in a DM, the round button at the top right that opens the full web client drew its icon in the Bot's primary colour.

After: the icon is the foreground colour (fg), the same as the Back button, in DMs and group Channels.

How: since #1889 the header renders inside the chat's AccentProvider, so FullClientIcon picked up the Bot accent. It now reads useDesignTheme().color.fg. DESIGN.md and the #1875 change fragment say both header icons are fg.

Light Dark
light dark

Checks: mobile typecheck, mobile vitest (370 passed), pnpm lint, oxfmt --check, and scripts/e2e-mobile-follow-latest-web.mjs.

🤖 Generated with Claude Code

https://claude.ai/code/session_01LzUNRQhy85WgjWULziwrxc


Generated by Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Updated the full-client button icon to use the standard text color instead of the Bot’s theme accent, giving it a consistent appearance in the chat header.

The open-in-web button now sits inside the chat's AccentProvider, so its
icon took the Bot's primary colour. Use the foreground colour, like Back.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LzUNRQhy85WgjWULziwrxc
@coderabbitai

coderabbitai Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 765cd246-5aab-484a-89c3-d23131e9abc3
📥 Commits

Reviewing files that changed from the base of the PR and between 452ec59 and b36e897.

⛔ Files ignored due to path filters: 2
  • .github/pr-screenshots/mobile-full-client-icon-fg/dm-dark.png is excluded by !**/*.png
  • .github/pr-screenshots/mobile-full-client-icon-fg/dm-light.png is excluded by !**/*.png
📒 Files selected for processing: 3
  • apps/mobile/DESIGN.md
  • apps/mobile/src/ui/open-full-client.tsx
  • changes/1875-mobile-chat-header.md

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

The full-client icon now uses the design theme foreground color. The design requirements no longer require the Back and computer buttons’ frosted fill and hairline edge on every platform. The English and Chinese change descriptions now mention a right-side full-client button and text-colored header buttons.

Changes: Mobile chat header

Layer / File(s) Summary
Header icon styling and documentation
apps/mobile/src/ui/open-full-client.tsx, apps/mobile/DESIGN.md, changes/1875-mobile-chat-header.md
FullClientIcon now uses the design theme foreground color for its frame and strokes. The design requirements and English and Chinese change descriptions are updated. The descriptions specify a right-side full-client button and text-colored header buttons.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to b36e8

The full-client icon uses the intended text color in DM and group-channel headers. No actionable merge risk is evident in the reviewed changes.

Pre-merge checks: Passed 3 · Failed 2

Failed Failed checks: 2 warnings

Check name Status Explanation Resolution
Description check Warning The description explains the problem, implementation, affected contexts, verification commands, and includes light and dark screenshots. It does not provide the required merge-risk assessment or CI te… Add a Special things to note section that states the merge risk, rollback or reversibility, blast radius, and review focus. State the CI test plan mode selected by scripts/ci-plan.mjs. Expand Verification to classify each check as automated…
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files. (2 skipped: 2 … Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 3 passed
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: updating the mobile chat header full-client icon to use the foreground colour.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the problem, implementation, affected contexts, verification commands, and includes light and dark screenshots. It does not provide the required merge-risk assessment or CI test plan, and the verification section does not distinguish automated tests, runtime checks, visual evidence, and Human QA.

Resolution

Add a Special things to note section that states the merge risk, rollback or reversibility, blast radius, and review focus. State the CI test plan mode selected by scripts/ci-plan.mjs. Expand Verification to classify each check as automated, runtime, visual, or Human QA, and explicitly list any checks that were not run.

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files. (2 skipped: 2 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches: 💡 1
📝 Generate docstrings: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@DoodleBears

Copy link
Copy Markdown
Contributor Author

Batch 5 result — partial

PR input b36e8973d4aff1b4e1d08c6b6f43738c4d71d553. Integrated native batch a42bc7ce27d0fd798c680f966a01b85b887fef0f, main 1d5ccf72a; one shared iOS 26.0 Simulator, one Metro, reused dev client, no native rebuild. Dedicated QA Host kept running to preserve approvals. Batch build/typecheck passed; mobile+Client 2152 passed / 9 skipped. No remote PR merge, phone installation or deployment.

  • PASS tint: native Ada QA DM and Activity QA group, light/dark; full-client glyph matches the Back/foreground colour rather than Bot accent.
  • PARTIAL entry: tap opens web mode, but content remained at a spinner across multiple observations; Exit web mode returned to native chat. Loading success is NOT claimed; not diagnosed as a tint regression.
  • Android and Human QA untested. Unified e2e failed at the initial Expo-menu-obscured pair-screen assertion, before these targeted checks.

Light group foreground icon Dark group foreground icon

DM light/dark pairs are embedded in #1928. Queue/report records the remaining viewer steps as blocked/untested. Lane released; no second Simulator.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants