Repository navigation
Show a build id in Settings on the Web Client and the mobile app - #1922
DoodleBears wants to merge 2 commits into
Conversation
… mobile The Web Client bundle gets the stamp from tsdown.config.ts and shows it as a Build row under Settings → About. The mobile app gets it from a new app.config.ts (extra.build), so Metro and the Release build's Generate app.config phase both stamp it, and the Settings sheet shows it under About. Both fall back to dev; BOTHARNESS_BUILD_SHA/TIME override git. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 46 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
… drop code comments Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Superseded by #1923. Its web half (build-id.ts, the About → Build row, the locale key, tsdown buildStamp and the test) was ported there unchanged. Mobile uses #1923's Metro env approach instead of app.config.ts extra, which would change the Expo native fingerprint on every build. Closing this one. Generated by Claude Code |
Requested by Vain
Why the change
During device QA nobody could tell which build was installed on the phone or served by the Web Client. Both now show a build id (short git SHA + build time) in Settings / 测试时看不出手机和网页端装的是哪一版,现在两端设置里都会显示构建号(git 短 SHA + 构建时间)。
Issue / Discussion: requested by the owner in the device-QA thread.
Special things to note
packages/client/lib, not committed) is stamped; the committed Browser/Computer bundles are untouched, so the verify workflow'sgit diff --exit-codeon them is unaffected. Mobile addsapps/mobile/app.config.ts, which only extendsapp.jsonwithextra.build; reverting it falls back to "dev".tsdown.config.tsbuildStamp()runsgit rev-parse --short=9 HEADat bundle time. Mobile — Expo evaluatesapp.config.tswhen Metro starts and in the Release build's "Generate app.config" phase.BOTHARNESS_BUILD_SHA/BOTHARNESS_BUILD_TIMEoverride git (e.g. CI); without git it showsdev.pnpm typecheck(root + mobile) clean; oxlint on the changed files clean; vitestapps/mobile/test+packages/client/test: 278 files, 2124 tests passed (new:apps/mobile/test/build-id.test.ts,packages/client/test/build-id.test.ts, a Settings-sheet About/Build case). Visual evidence follows in a comment from the Simulator and the QA Host Web Client.Change outline
d9bbfbdfe · 2026-10-15 18:30(local time) ordev.SettingsViewtakes abuildprop (defaultdev); the Settings route reads it fromexpo-constants.🤖 Generated with Claude Code