Skip to content

fix(mobile): stop expo start from rewriting tsconfig.json (build id showed "-dirty") - #1925

Merged
DoodleBears merged 1 commit into
mainfrom
claude/project-thread-b5m1m8
Oct 15, 2026
Merged

DoodleBears merged 1 commit into
mainfrom
claude/project-thread-b5m1m8

Conversation

@DoodleBears

Copy link
Copy Markdown
Contributor

Requested by Vain · project thread

Why the change

After #1923, every expo start rewrote apps/mobile/tsconfig.json. That left the tree dirty, so the build id in Settings → About always ended in -dirty / 每次 expo start 都会改写 tsconfig.json,导致构建号总带 -dirty。

Special things to note

  • Merge risk: none at runtime. One line is removed from tsconfig.json.
  • Cause: with typed routes off, Expo's TypeScript setup removes expo-env.d.ts from include on every start and writes the file back in its own JSON layout. expo-env.d.ts is gitignored and not generated here, so the entry did nothing.
  • Verification:
    • EXPO_OFFLINE=1 CI=1 npx expo start: on main it produces a tsconfig.json diff, and with this change it leaves the file untouched.
    • pnpm --filter @botharness/mobile typecheck and oxfmt --check pass.
  • CI test plan: affected.

Change outline

   "include": [
     "app",
     "src",
-    "expo-env.d.ts",

🤖 Generated with Claude Code

https://claude.ai/code/session_01RESQX8EVBt9d4fGKdV4ips


Generated by Claude Code

…eaves it alone

Expo removes the entry on every start (typed routes are off), which made the
tree dirty and the Settings build id read "-dirty".

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RESQX8EVBt9d4fGKdV4ips
@DoodleBears DoodleBears self-assigned this Oct 15, 2026
@coderabbitai

coderabbitai Bot commented Oct 15, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 21 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 25397bd4-b7a9-4a69-8c37-d6223c33894e
📥 Commits

Reviewing files that changed from the base of the PR and between 8309eca and 3e846da.

📒 Files selected for processing: 1
  • apps/mobile/tsconfig.json
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@DoodleBears
DoodleBears merged commit 3c73acf into main Oct 15, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants