Repository navigation
fix(mobile): stop expo start from rewriting tsconfig.json (build id showed "-dirty") - #1925
Merged
Merged
Conversation
…eaves it alone Expo removes the entry on every start (typed routes are off), which made the tree dirty and the Settings build id read "-dirty". Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RESQX8EVBt9d4fGKdV4ips
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 21 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Vain · project thread
Why the change
After #1923, every
expo startrewroteapps/mobile/tsconfig.json. That left the tree dirty, so the build id in Settings → About always ended in-dirty/ 每次expo start都会改写 tsconfig.json,导致构建号总带-dirty。Special things to note
tsconfig.json.expo-env.d.tsfromincludeon every start and writes the file back in its own JSON layout.expo-env.d.tsis gitignored and not generated here, so the entry did nothing.EXPO_OFFLINE=1 CI=1 npx expo start: on main it produces atsconfig.jsondiff, and with this change it leaves the file untouched.pnpm --filter @botharness/mobile typecheckandoxfmt --checkpass.Change outline
"include": [ "app", "src", - "expo-env.d.ts",🤖 Generated with Claude Code
https://claude.ai/code/session_01RESQX8EVBt9d4fGKdV4ips
Generated by Claude Code