Add condition when clearing polyline location properties#58
Open
philip-khaisman wants to merge 1 commit into
Open
Add condition when clearing polyline location properties#58philip-khaisman wants to merge 1 commit into
philip-khaisman wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When starting the webtak plugin we call the discovery service and create the necessary layers for the results. It's not guaranteed that these layers will receive data. For example if i have a system with only historical data and i never play it back. This causes a problem because if the View is ever reset (either when the broadcast channel receives a time changed or closed error) it makes a call to clear all the layers. The layer clear previously assumed that it had received data so it would crash when trying to access a property that was never set (propsById). The fix adds an if condition to check if the property exists before accessing it. If it doesn't exist there is nothing to clear.
Tested by running a db file which i will provide in replay mode. It had 5 minutes of data. After 5 minutes i would see the error as a webpack modal. This is because the socket is closed after 5 minutes. With the fix you will not see the error and they replay driver should loop without error