Repository navigation
Scenario workflow: 10. baseline workflow builder - #18
Merged
JieXiong9119 merged 1 commit intoNov 5, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why do we need this PR
This is PR 10 of the scenario workflow plan. Baseline OSW assembly was mixed into the file-writing code in
write_baseline_osw. Moving it into a separate builder lets later scenario PRs reuse the baseline workflow without writing it to disk first.Core change explanation
BOSS.build_baseline_osw(bsync_reader)that loads the template, runs the eight baseline populators, callsconfigure_osw, orders measure and file paths (local → gem → external), and returns the OSW hash.write_baseline_oswnow validates the XML, builds the reader, calls the builder, and writesbaseline/in.osw. Its public API, CLI behavior and output layout are unchanged.run_baseline_oswis unchanged.Which files are affected
lib/BOSS/boss.rbspec/tests/unit/boss_spec.rbdocs/scenario_workflow_translation_plan.mdWhat kind of tests are done
building_151andall_measures_applied_exampleare identical to the pre-refactor output,bundle exec rspec spec/tests/unit: 112 examples, 0 failures.bundle exec rubocop lib/BOSS/boss.rb spec/tests/unit/boss_spec.rb: the only new offense isMetrics/BlockLengthon the spec's top-level block.building_151andall_measures_applied_example: both succeeded, all 8 steps completed. I checked the generated models against the source XML; they match apart from defaults used where the XML has no data.bundle exec rspec spec/tests/integration/write_and_run_osws_spec.rb) andbundle exec rake.Out of scope / Follow-up work
all_measures_applied_example(Denver, climate zone 5B) runs with the wrong weather file. Fix by stubbing weather per fixture.rake measures:install_external; without it, the run fails with "Cannot find measure 'replace_baseline_windows'".