Repository navigation
Conversation
… 2.7.0 - Regenerate bsync.py from the v2.7.0 release XSD (52 elements added, none removed) - requires-python >=3.11; lxml >=5.0 (lxml 4 has no wheels past cp312) - Move metadata to the PEP 621 [project] table (Poetry 2) and refresh poetry.lock - CI: test matrix 3.11-3.14, generator checks for BuildingSync 2.3-2.7 and the develop-v2/develop-v3 branches, current action versions - Add Dependabot config; bump black to 26.10.1 - Bump version to 0.4.0 and update README/CHANGELOG Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
🟡 Changes recommended
The change makes valid audit-cycle indices raise a ValueError because BSElement lacks positiveInteger handling, which must be added before regenerating bsync.py.
1 open issue
What changed in this PR
This PR prepares bsyncpy 0.4.0 with BuildingSync 2.7.0 bindings and modernizes Python support, packaging, and maintenance automation.
Changes:
- Regenerates schema bindings with condition fields, file attachments, federal identifiers, and life-cycle savings.
- Requires Python 3.11+, allows lxml 5/6, and migrates metadata to PEP 621.
- Expands CI coverage, adds Dependabot, and updates formatting tools and release documentation.
| File | Description |
|---|---|
tests/test_basic.py |
Updates the expected BuildingSync version to 2.7.0. |
README.md |
Updates supported versions, examples, and generation instructions. |
pyproject.toml |
Modernizes metadata and dependencies; bumps version to 0.4.0. |
poetry.lock |
Refreshes dependency versions and lock format. |
CHANGELOG.md |
Documents the 0.4.0 release changes. |
bsyncpy/bsync.py |
Regenerates bindings for BuildingSync 2.7.0. |
.pre-commit-config.yaml |
Updates Black and removes the interpreter override. |
.github/workflows/ci.yml |
Adds Python and schema matrices with generated-module smoke checks. |
.github/dependabot.yml |
Adds weekly grouped dependency and action updates. |
Review effort: Balanced
| class IndexYearOfAuditCycle(BSElement): | ||
| """Index number of the year when the audit is conducted from the start of the audit cycle. 1 corresponds to auc:AuditCycleStartYear.""" | ||
|
|
||
| element_type = "xs:positiveInteger" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

bsync.pyfrom the BuildingSync v2.7.0 release XSD (52 elements added, none removed)[project]table (Poetry 2) and refreshedpoetry.lockdevelop-v2/develop-v3branches🤖 Generated with Claude Code