Repository navigation
Conversation
- TimeSeriesReadingQuantity Currency -> Cost - OutputCapacity -> Capacity - Site/WeatherDataStationID and WeatherStationName -> Site/WeatherStations/WeatherStation Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kflemin
added
Non-breaking Change
Schema: No Changes
kflemin
requested review from
JieXiong9119
and
a balanced review from Copilot
November 6, 2026 21:46
There was a problem hiding this comment.
🟢 Approval recommended
There are no active review issues for the updates aligning the examples with current schema conventions.
No open issues 🎉
What changed in this PR
Updates eight BuildingSync examples to replace deprecated usage reported by #568, keeping the examples aligned with current schema conventions. No schema changes are included, and the intentionally invalid example remains unchanged.
Changes:
- Replaces 55
TimeSeriesReadingQuantityvalues fromCurrencytoCost. - Replaces deprecated boiler and heating-source
OutputCapacityelements withCapacity. - Moves site weather-station data into
WeatherStations/WeatherStationcontainers.
| File | Description |
|---|---|
examples/Single_building_gbxml_externalreference_geometry.xml |
Updates weather-station structure and boiler capacity. |
examples/Reference Building - Primary School.xml |
Updates weather-station structure and boiler capacity. |
examples/BuildingSync Website Valid Schema.xml |
Uses the nested weather-station structure. |
examples/BuildingEQ-1.0.0.xml |
Replaces heating-source OutputCapacity with Capacity. |
examples/AT_example_SF_audit_report.xml |
Updates boiler and heating-source capacity elements. |
examples/AT_example_NYC_audit_report_property.xml |
Updates boiler and heating-source capacity elements. |
examples/AT_example_AS_conversion_audit_report.xml |
Updates boiler and heating-source capacity elements. |
examples/ASHRAE 211 Export.xml |
Uses Cost for monetary time-series readings. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the deprecated usages reported by the deprecated-elements check (#568) in
examples/:TimeSeriesReadingQuantityCurrency→Cost(ASHRAE 211 Export.xml)OutputCapacity→Capacityin Boiler/HeatingSource (AT examples,BuildingEQ-1.0.0.xml,Reference Building - Primary School.xml,Single_building_gbxml_externalreference_geometry.xml)Site/WeatherDataStationID+WeatherStationName→Site/WeatherStations/WeatherStation(BuildingSync Website Valid Schema.xml,Reference Building - Primary School.xml,Single_building_gbxml_externalreference_geometry.xml)No schema changes.
BuildingSync Website Invalid Schema.xmlleft as is.🤖 Generated with Claude Code