fix: use identity check for None in ascii_tree - #1231
Open
abhi-0203 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
ascii_treeraisingValueErrorwhen a DataFrame is supplied as thedfparameter.The function checked
if df == None, which is elementwise comparison for DataFrames, causing pandas to raiseValueError: The truth value of a DataFrame is ambiguous. This changes the check toif df is None, which correctly checks forNoneand allows using a caller-provided DataFrame.Closes #1224.
Testing
ascii_tree(DT)(default path) still works.ascii_tree(DT, df)now uses the provided DataFrame and no longer raises.