Bumping cmake_minimum_required to fix FTBFS with cmake 4. - #135
Open
daniel-baumann wants to merge 1 commit into
Open
Bumping cmake_minimum_required to fix FTBFS with cmake 4.#135daniel-baumann wants to merge 1 commit into
daniel-baumann wants to merge 1 commit into
Conversation
Signed-off-by: Daniel Baumann <daniel@debian.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
cmake 4 raised the minimum feature baseline for cmakefiles, ipfixcol2 does meet all of them, however, it makes sense to set it to the lowest number of the syntax that cmake 4 supports for maximum compatibility.
This is the patch we've applied in Debian, it would be nice if you could merge it.
Regards,
Daniel