Repository navigation
Bump Axios 1.19 to 1.20 - #199
BenColeCode wants to merge 1 commit into
Conversation
| "@types/react-dom": "^18.2.0", | ||
| "@vitejs/plugin-react-swc": "^3.7.2", | ||
| "axios": "^1.19.0", | ||
| "axios": "^1.20.0", |
There was a problem hiding this comment.
We'll need to ensure that we commit package-lock.json AND yarn.lock as well so us developers don't have to run npm i or yarn install and can just use the latest lock file version.
| "axios": "^1.19.0", | ||
| "axios": "^1.20.0", | ||
| "js-yaml": "^4.3.2", | ||
| "micromatch": "4.0.8", |
There was a problem hiding this comment.
I seem to be getting an exit 100 error when trying to do docker compose up - might be good to huddle to see why - seems like it's occurring for me in the get-apt-update step of the docker file in server directory. Having @bwang-icf try to get another data point
There was a problem hiding this comment.
I'm able to get this spun up and working as is
There was a problem hiding this comment.
Idk I keep getting an error - will bring it up at eng sync. @bwang-icf can take over the review - I would just verify the latest version update of axios 1.20.0 is in the container and the lock files are committed.
3 participants
JIRA Ticket:
BB2-5258
What Does This PR Do?
Upgrades the version of axios from 1.19.0 to 1.20.0
What Should Reviewers Watch For?
Does the server still build?
Validation
run docker compose up
check for failures