fix: Killing processes does not take place when they are in D-State#255
Merged
Conversation
This issue occurs after a database restart or when running a systemctl restart flow-capture. There are two change elements. The first is moving the systemd KillMode to mixed which signals the parent with a SIGTERM and children processes with a SIGKILL, and changing the internal signaling process to always use a SIGKILL.
There was a problem hiding this comment.
Pull request overview
This PR updates FlowView process termination behavior so service shutdown and parent-driven child cleanup use more forceful process killing, intended to address collectors stuck during database/service restarts.
Changes:
- Changes the systemd unit from
KillMode=processtoKillMode=mixed. - Changes FlowView child termination from
SIGTERMtoSIGKILL. - Adds a changelog entry for the D-State process termination issue.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
service/flow-capture.service |
Updates systemd kill behavior for the service cgroup. |
service/flow-capture |
Forces child collector termination with SIGKILL. |
CHANGELOG.md |
Records the process-killing issue under develop. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
xmacan
approved these changes
May 29, 2026
bmfmancini
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue occurs after a database restart or when running a systemctl restart flow-capture. There are two change elements. The first is moving the systemd KillMode to mixed which signals the parent with a SIGTERM and children processes with a SIGKILL, and changing the internal signaling process to always use a SIGKILL.