TypeFactory::build() support #45

Activity

1. rochamarcelo commented on May 19, 2025

   

   rochamarcelo

   on May 19, 2025

   Contributor

   More actions

   It should be able to understand based on default values of TypeFactory::$_types using an extension, maybe it is also possible with annotations.
2. rochamarcelo commented on May 20, 2025

   

   rochamarcelo

   on May 20, 2025

   Contributor

   More actions

   Found this but it is using constant https://phpstan.org/r/a01e1e49-6f05-43a8-aac7-aded770cd88a
3. dereuromark commented on May 20, 2025

   

   dereuromark

   on May 20, 2025

   Last edited by dereuromark

   CollaboratorAuthor

   More actions

   A manual strategy could be sth like

   namespace App\PHPStan;
   
   use PhpParser\Node\Expr\StaticCall;
   use PHPStan\Analyser\Scope;
   use PHPStan\Reflection\MethodReflection;
   use PHPStan\Type\DynamicStaticMethodReturnTypeExtension;
   use PHPStan\Type\Type;
   use PHPStan\Type\ObjectType;
   use PHPStan\Type\MixedType;
   
   class TypeFactoryBuildReturnTypeExtension implements DynamicStaticMethodReturnTypeExtension
   {
       public function getClass(): string
       {
           return \Cake\Database\TypeFactory::class;
       }
   
       public function isStaticMethodSupported(MethodReflection $methodReflection): bool
       {
           return $methodReflection->getName() === 'build';
       }
   
       public function getTypeFromStaticMethodCall(
           MethodReflection $methodReflection,
           StaticCall $methodCall,
           Scope $scope
       ): Type {
           if (count($methodCall->getArgs()) === 0) {
               return new MixedType();
           }
   
           $argType = $scope->getType($methodCall->getArgs()[0]->value);
   
           if ($argType->isString()->yes()) {
               $constantStrings = $argType->getConstantStrings();
               if (count($constantStrings) === 1) {
                   $typeName = $constantStrings[0]->getValue();
                   if ($typeName === 'datetime') {
                       return new ObjectType(\Cake\Database\Type\DateTimeType::class);
                   }
                   // Add more mappings
               }
           }
   
           return new MixedType();
       }
   }

   We should be able to automate this based on Name/Namespace I guess even.
4. rochamarcelo commented on May 20, 2025

   

   rochamarcelo

   on May 20, 2025

   Contributor

   More actions

   Could rely on predefined values from $_types, also return null instead of MixedType to fallback to method return type

   👍React with 👍1Reacted by Mark Scherer
5. rochamarcelo commented on May 20, 2025

   

   rochamarcelo

   on May 20, 2025

   Contributor

   More actions

   What do you think about using annotation instead of an extension @dereuromark ?

   This would require to add constant in the class and use that as 'template'. The existing property would refer to the new constant: protected static array $_types = self:TYPES;

   Example: https://phpstan.org/r/b7d9e97a-8d3e-4462-8b03-f30ea6942f97
6. dereuromark commented on May 20, 2025

   

   dereuromark

   on May 20, 2025

   CollaboratorAuthor

   More actions

   Well we are mainly using it in bootstrap
   And maybe a few other places.

   The extension would just make it work out of the box :)

   👍React with 👍1Reacted by Marcelo Rocha
7. dereuromark

   closed this as completedon Oct 15, 2025
8. dereuromark commented on Oct 15, 2025

   

   dereuromark

   on Oct 15, 2025

   CollaboratorAuthor

   More actions

   #58