Skip to content

fix: harden recording creation, share playback, and desktop reliability - #2300

Open
richiemcilroy wants to merge 3 commits into
mainfrom
fix/recording-share-reliability-20260916
Open

richiemcilroy wants to merge 3 commits into
mainfrom
fix/recording-share-reliability-20260916

Conversation

@richiemcilroy

@richiemcilroy richiemcilroy commented Sep 16, 2026

Copy link
Copy Markdown
Member

A failed upload-progress insert could leave a newly created recording without its progress row. The affected web, desktop, and mobile creation paths now commit both rows in one transaction. A media error on an initial signed MP4 URL triggers one authorized refresh; playback restores the playhead and resumes if it was active. Abandoned editor construction aborts segment loading. Windows builds compile only the memory-pressure states they can sample. GPUI asset validation now sees the Windows caption controls and embeds only icons still used by its windows; its generated lockfile includes the dependency required by editor cancellation.

Validation: 223 focused and adjacent web tests passed; the editor crate checked and 184 Rust tests passed (3 ignored). The utils crate checked, 12 export-resource tests passed (1 ignored), and strict local Clippy passed. The GPUI crate checked with locked dependencies and all four focused asset tests passed. Scoped Biome, Cargo formatting, backend TypeScript, and isolated-diff whitespace checks passed. Exact-head CI passed all required checks, including Linux, macOS, and Windows desktop builds and GPUI tests, strict Clippy, typecheck, Biome, native sync, and recording recovery. Browser playback and Windows native editor interaction were unavailable locally.

RetriggerConfidence Score: 5/5

The PR appears safe to merge, with no outstanding actionable failures identified in the current changes.

Summary

This PR makes recording and upload-progress creation atomic across web, desktop, mobile, and backend paths; refreshes expired signed playback sources while preserving playback state; cancels abandoned editor segment loading; corrects platform-specific memory-pressure compilation; and aligns GPUI assets and lockfiles.

  • Creates video and initial upload rows in the same database transaction.
  • Adds one-time signed-source refresh with playhead and playing-state restoration.
  • Aborts segment-loading tasks when editor construction is abandoned.
  • Restricts memory-pressure variants to supported platforms.
  • Updates GPUI asset validation and generated dependency locks.

Reviews (3) · Last reviewed commit: "fix: align desktop icon validation and d..."

@richiemcilroy

Copy link
Copy Markdown
Member Author

hey @greptileai, please re-review the PR

@richiemcilroy richiemcilroy changed the title fix: harden video creation, playback, and editor setup fix: harden recording creation, share playback, and desktop media Sep 16, 2026
@richiemcilroy richiemcilroy changed the title fix: harden recording creation, share playback, and desktop media fix: harden recording creation, share playback, and desktop reliability Sep 16, 2026
@richiemcilroy

Copy link
Copy Markdown
Member Author

hey @greptileai, please re-review the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant