fix: harden recording creation, share playback, and desktop reliability - #2300
Open
richiemcilroy wants to merge 3 commits into
Open
richiemcilroy wants to merge 3 commits into
richiemcilroy wants to merge 3 commits into
Conversation
Member
Author
|
hey @greptileai, please re-review the PR |
Member
Author
|
hey @greptileai, please re-review the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A failed upload-progress insert could leave a newly created recording without its progress row. The affected web, desktop, and mobile creation paths now commit both rows in one transaction. A media error on an initial signed MP4 URL triggers one authorized refresh; playback restores the playhead and resumes if it was active. Abandoned editor construction aborts segment loading. Windows builds compile only the memory-pressure states they can sample. GPUI asset validation now sees the Windows caption controls and embeds only icons still used by its windows; its generated lockfile includes the dependency required by editor cancellation.
Validation: 223 focused and adjacent web tests passed; the editor crate checked and 184 Rust tests passed (3 ignored). The utils crate checked, 12 export-resource tests passed (1 ignored), and strict local Clippy passed. The GPUI crate checked with locked dependencies and all four focused asset tests passed. Scoped Biome, Cargo formatting, backend TypeScript, and isolated-diff whitespace checks passed. Exact-head CI passed all required checks, including Linux, macOS, and Windows desktop builds and GPUI tests, strict Clippy, typecheck, Biome, native sync, and recording recovery. Browser playback and Windows native editor interaction were unavailable locally.
The PR appears safe to merge, with no outstanding actionable failures identified in the current changes.
Summary
This PR makes recording and upload-progress creation atomic across web, desktop, mobile, and backend paths; refreshes expired signed playback sources while preserving playback state; cancels abandoned editor segment loading; corrects platform-specific memory-pressure compilation; and aligns GPUI assets and lockfiles.
Reviews (3) · Last reviewed commit: "fix: align desktop icon validation and d..."