Remove dead-host setless URL entries for tokens now in TDLS#10540
Open
vanja-ivancevic wants to merge 1 commit intoCard-Forge:masterfrom
Open
Remove dead-host setless URL entries for tokens now in TDLS#10540vanja-ivancevic wants to merge 1 commit intoCard-Forge:masterfrom
vanja-ivancevic wants to merge 1 commit intoCard-Forge:masterfrom
Conversation
The Card Conjurer-rendered TDLS (Duelist Magazine) tokens registered in PR Card-Forge#10518 introduced edition-specific URLs for thrull, saproling, citizen, camarid, and goblin. The old setless entries pointing at downloads.cardforge.org (DNS NXDOMAIN since at least 2025-04) have been unreachable for some time, but on legacy clients they wrote loose pics/tokens/<script>.jpg files years ago. When Forge now picks TDLS via era-match and the per-edition cache is empty, the lookup chain falls through to those legacy loose files (ImageKeys.getImageFile setless fallback) and serves stale modern-frame art instead of the new TDLS download. Removing these 5 dead entries prevents fresh installs from ever producing the conflicting loose files. Existing affected users still need a one-time cleanup of pics/tokens/*.jpg loose files to recover. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Should we delete all dead cardforge URLs? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #10518.
token-images.txt(b_0_1_thrull.jpg,g_1_1_saproling.jpg,w_1_1_citizen.jpg,u_1_1_camarid.jpg,r_1_1_goblin.jpg) that point atdownloads.cardforge.org, a host with no DNS A record (NXDOMAIN). All 5 URLs return HTTP 000 (no connection possible) from any client today.pics/tokens/<script>.jpgfiles. When Forge now picks TDLS via the new era-match preference and the per-edition cache is empty,ImageKeys.getImageFilefalls through its lookup chain to those loose files and serves stale modern-frame art. Removing the entries means fresh installs cannot produce the conflicting loose files in the first place..jpgfiles at the root ofpics/tokens/to clear their stale cache. That is a one-time cleanup, not a code fix.